Skip to content
This repository has been archived by the owner on Oct 18, 2020. It is now read-only.

Do not use opam config exec #201

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Do not use opam config exec #201

merged 1 commit into from
Aug 9, 2018

Conversation

reynir
Copy link
Member

@reynir reynir commented Jul 11, 2018

When invoking ocamlfind. The environment should be setup correctly, I believe, and on opam2 this will fail due to the sandbox preventing opam config exec writing logs.

Fixes #200

When invoking `ocamlfind`. The environment should be setup correctly, I believe, and on opam2 this will fail due to the sandbox preventing `opam config exec` writing logs.
@hannesm
Copy link
Member

hannesm commented Jul 11, 2018

the other call to opam config exec in the build.sh is not an issue?

@reynir
Copy link
Member Author

reynir commented Jul 11, 2018

The other call you mention I believe is opam config var prefix. It's not an issue (except on qubes ocaml/opam#3446), although I think it can be rewritten to use $OPAM_SWITCH_PREFIX. I can add this to the PR after I confirm this.

@samoht
Copy link
Member

samoht commented Jul 11, 2018

LGTM

@samoht samoht merged commit 77ee5f5 into mirage:master Aug 9, 2018
samoht added a commit to samoht/opam-repository that referenced this pull request Aug 9, 2018
CHANGES:

* xen: do not use `opam config exec` during the build to be compatible
  with opam2 (mirage/mirage-platform#201, @reynir)
samoht added a commit to samoht/opam-repository that referenced this pull request Aug 9, 2018
CHANGES:

* xen: do not use `opam config exec` during the build to be compatible
  with opam2 (mirage/mirage-platform#201, @reynir)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants