port to dune #58
Merged
port to dune #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This was exactly the kind of change I had in mind -- ports only the build system without any public API changes. Well done. |
Closed
kit-ty-kate
pushed a commit
to kit-ty-kate/mirage-solo5
that referenced
this pull request
Oct 6, 2022
add support for OCaml 4.08.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with #41 in mind, other mirage-solo5-* libraries have already been ported to dune (mirage-solo5 seems to be the only one which still uses topkg/ocamlbuild). In the light of the reviews of #47 (which is superseeded by this PR), I pushed a commit here that I had lying around for some while. It keeps the names (
libmirage-solo5_bindings.afor the C stubs, built with thepkg-config'd ocaml-freestanding CFLAGS (by calling out tocflags.shwhich calls pkg-config), the OCaml module is stillOS), but ports the build system to dune.the advantage from a maintenance point of view is that there's no longer any need to remember topkg and dune-release runes. existing mirage-solo5-* packages (esp. mirage-net-solo5) install fine with this PR; also an end-to-end tested unikernels (from mirage-skeleton) work well.