add verify_transport_checksum to ipv4_packet.unmarshal #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
yomimono
force-pushed
the
transport_checksums
branch
from
bbdc1a7
to
b33ec56
Compare
Add a function `verify_transport_checksum` to ipv4_packet.unmarshal. As the function needs to use Tcp_wire and Udp_wire, include the UDP and TCP sublibraries when building Ipv4. Also include some tests against pre-created packets with good checksums.
yomimono
force-pushed
the
transport_checksums
branch
from
b33ec56
to
8a06c47
Compare
samoht
reviewed
Jan 5, 2017
| @@ -58,7 +58,9 @@ Library ipv4 | |||
| Modules: Static_ipv4, Ipv4_wire, Ipv4_packet | |||
| InternalModules: Ipv4_common, Routing | |||
| BuildDepends: logs,io-page,mirage-types,ipaddr,cstruct.ppx,lwt,result,rresult, | |||
| tcpip,tcpip.ethif,mirage-runtime | |||
| mirage-runtime, | |||
There was a problem hiding this comment.
do we still need mirage-runtime in there?
There was a problem hiding this comment.
No, #283 removes it.
There was a problem hiding this comment.
(It is needed with this patchset.)
samoht
pushed a commit
that referenced
this pull request
Apr 4, 2017
add verify_transport_checksum to ipv4_packet.unmarshal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function
verify_transport_checksumto ipv4_packet.unmarshal. Asthe function needs to use Tcp_wire and Udp_wire, include the UDP and
TCP sublibraries when building Ipv4.
Also include some tests against pre-created packets with good checksums.
/cc @haesbaert , as this is intended for use to replace the checksum validation that I removed a little while ago in charrua-core.