remove unused pattern match in tcp writes #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`No_route` is now the only error variant, so these cases were not used: ``` File "lib/tcp/pcb.ml", line 606, characters 12-19: Warning 11: this match case is unused. File "lib/tcp/pcb.ml", line 644, characters 6-13: Warning 11: this match case is unused. ``` Remove them.
samoht
pushed a commit
to samoht/mirage-tcpip
that referenced
this pull request
May 30, 2017
…-tcp remove unused pattern match in tcp writes
hannesm
added a commit
to hannesm/mirage-tcpip
that referenced
this pull request
Feb 7, 2020
djs55
pushed a commit
to djs55/mirage-tcpip
that referenced
this pull request
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No_routeis now the only error variant, so these cases were not used:Remove them.