Dependencies and build adjustments #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PATH The dune version in dune-project is 2.6.0, reflect the same version in opam. The PKG_CONFIG_PATH is evaluated in lib/bindings/Makefile explicitly, the data in OPAM_PKG_CONFIG_PATH passed via opam is not respected, remove it. Also remove unused top-level Makefile.
This is used in activations and xen, avoid implicit dependencies. It is already declared in the opam file.
|
FWIW I PRed upper bounds & conflicts at ocaml/opam-repository#17430 -- once this is merged, mirage-xen.opam >= 6.0.0 won't need to conflict with mirage-xen-posix,mirage-xen-ocaml,mirage-xen-minios,minios-xen (since all released mirage-xen-ocaml & mirage-xen-posix are in conflict with mirage-xen >= 6.0.0). |
Since ocaml/opam-repository#17430 all mirage-xen-ocaml and mirage-xen-posix conflict with mirage-xen >= 6.0.0. There's no need to put these conflicts in mirage-xen.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanups, see individual commits for details.