mirage: impose a 4k limit on header lengths #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the HTTP spec does not impose a maximum limit on header lengths, most implementations impose a limit to avoid a client from exhausting all available server memory. According to https://stackoverflow.com/a/8623061 the typical limit is between 4k and 48k, but this usually applies to the sum of the request line and all the headers. It's more convenient for us to apply the limit per header. This requires [mirage/mirage-channel#25] Signed-off-by: David Scott <dave@recoil.org>
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
May 1, 2018
This imports mirage/ocaml-cohttp#612 Signed-off-by: David Scott <dave.scott@docker.com>
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
May 1, 2018
This imports mirage/ocaml-cohttp#612 Signed-off-by: David Scott <dave.scott@docker.com>
|
Is this still needed? |
|
Feel free to reopen and ping me if it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the HTTP spec does not impose a maximum limit on header lengths, most implementations impose a limit to avoid a client from exhausting all available server memory.
According to https://stackoverflow.com/a/8623061 the typical limit is between 4k and 48k, but this usually applies to the sum of the request line and all the headers. It's more convenient for us to
apply the limit per header.
This requires [mirage/mirage-channel#25]
Signed-off-by: David Scott dave@recoil.org