Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tls thread safe #358

Closed
wants to merge 6 commits into from
Closed

Tls thread safe #358

wants to merge 6 commits into from

Conversation

dinosaure
Copy link
Member

Try to fix #336

craigfe and others added 4 commits December 1, 2020 19:16
@craigfe @dinosaure
core: expand aliases exposed in _intf file
19a5830 
This ensures that the OCaml toplevel is able to introspect these
signatures directly  and prevents references to module types in
`Conduit_intf` from escaping to the user.

Fixes #356.
@dinosaure
.
f249028
@dinosaure
.
de83151
@dinosaure
.
ea7dd30
@dinosaure dinosaure mentioned this pull request Dec 2, 2020
Open
@samoht
Copy link
Member

samoht commented Dec 2, 2020

Do you mind cleaning up the history a little? The PR is very hard to review in its current form.

@dinosaure
Copy link
Member Author

Yes, it's draft I'm currently on a split of this PR.

@dinosaure
Copy link
Member Author

See #360, #361, #362 and #363.

@dinosaure dinosaure closed this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conduit-tls must be thread-safe
3 participants
@dinosaure @samoht @craigfe