Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stdlib #269

Merged
merged 4 commits into from
Nov 24, 2019
Merged

Use stdlib #269

merged 4 commits into from
Nov 24, 2019

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Oct 20, 2019

on top of #266 but also adding stdlib-shims for older ocaml compilers

Copy link
Member

@dinosaure dinosaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if CI fails.

@XVilka
Copy link
Contributor

XVilka commented Nov 21, 2019

Any reasons not to merge?

@avsm
Copy link
Member

avsm commented Nov 21, 2019

CI is failing. Looked at why?

@XVilka
Copy link
Contributor

XVilka commented Nov 21, 2019

@avsm it says "Build not found", so I guess should be restarted.

@avsm
Copy link
Member

avsm commented Nov 24, 2019

CI fixed, merging. Thanks!

@avsm avsm merged commit cc84e88 into mirage:master Nov 24, 2019
avsm added a commit to avsm/opam-repository that referenced this pull request Nov 24, 2019
…uct-sexp and cstruct-lwt (5.1.0)

CHANGES:

- Do not issue deprecation warnings when using OCaml 4.08.0
  and cstruct-ppx with enums due to `Pervasives` (mirage/ocaml-cstruct#269 @cypheon @hannesm)

- Tighten parsing of the `[@len]` attribute to ensure it is a
  valid, positive integer (mirage/ocaml-cstruct#265 @emillon)

- Update JavaScript bindings to latest `Js_of_ocaml` 3.5.0
  interfaces (@hhugo mirage/ocaml-cstruct#268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants