ci: Configure CI for NixOS #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Et7f3
force-pushed
the
add-nix-ci
branch
5 times, most recently
from
804b521
to
72fed2c
Compare
13 tasks
|
Thanks! |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Dec 7, 2022
CHANGES: - Add the NixOS CI to test `ocaml-git` (@Et7f3, mirage/ocaml-git#600, mirage/ocaml-git#473) - Specify few more headers fields when we fetch/push via HTTP (@reynir, @hannesm, @dinosaure, mirage/ocaml-git#603, mirage/ocaml-git#601) - Improve the error message about `Smart_git.Endpoint.of_string` (@reynir, @dinosaure, mirage/ocaml-git#605, mirage/ocaml-git#604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #473
You have opam2nix used in dune repo that convert automatically or you have curated list (by human) in nixpkgs
You have two workflow:
I opted for the solution with lower maintenance. It should catch most issue with NixOS + if a nix user want an old version it can always checkout an old version of nixpkgs (that is 100% reproductible) so it I would opt to avoid double maintenance.
Is it preferable to have all package's check enabled even the failing one or disabling them is fine ? What is mirage policy ? (Here I build all version without saving exit code so it it green)