Implement hub in Ocaml #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
reviewed
Jul 6, 2021
| @@ -1,32 +0,0 @@ | |||
| open Printf | |||
There was a problem hiding this comment.
intentionally deleting the releases binary here?
There was a problem hiding this comment.
Yes that is deliberate for 2 reasons:
- The
hubcommand can test the same code minor formatting differences aside
egdune exec -- hub/hub.exe release --owner mirage --repo ocaml-github - This binary wasn't listed in the dune file so it wasn't being compiled.
In future I'd like to have lib_test executables bundled into the hub command with some mdx tests wrapping them to provide some basic assurances.
|
This needs to add a |
|
I'm unlikely to work on this anytime soon, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.