Build system cleanups, provide minimal <inttypes.h> #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the use of build/ in the build system. This was forcing unnecessary ordering dependencies between nolibc, openlibm and the OCaml runtime, and making it necessary to jump through various hoops when doing "in-tree" development. An additional benefit is that parallel builds are now deterministic (always either fail due to a real error or complete fully), whereas previously they could randomly fail due to the ordering issue mentioned above. The OCaml runtime is now the only code that is copied into the tree, from $(ocamlfind query ocaml-src) into ocaml/. The following minor changes have also been done: - Replace unnecessary use of -isystem in the internal build with -I. This is actually harmful as it relaxes C standards applied to those headers in unpredictable ways, see [1]. [1] https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html#System-Headers and description of -isystem in https://gcc.gnu.org/onlinedocs/cpp/Invocation.html#Invocation
This change tests at build time that each nolibc-provided public header file is a) self-contained and b) compiles with no errors.
Add an inttypes.h derived from musl, providing only the PRIXXX macros for use by printf-style format strings.
dinosaure
approved these changes
May 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal here is to provide a minimal <inttypes.h>, which fixes #60. The associated changes improve the build system, notably adding compile-testing of all public headers provided by nolibc.
See individual commits for details:
/cc @hannesm @emillon @dinosaure (you asked for/could use an inttypes.h) @samoht (build system changes)