New packages for v1 & v2 engine #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib-vault depends on `github.com/hashicorp/vault` for test purproses. However, according the vault maintiners (hashicorp/vault#9575 (comment)) > No one should be importing github.com/hashicorp/vault, only the api and sdk modules. The top-level vault module is not intended to be a dependency for other projects, we're using go.mod solely to manage our own dependencies here. Also, the current referenced vault version has critical CVEs, and we are unable to upgrade it: Some failed trials: ``` ❯ go get -u github.com/hashicorp/vault go get: github.com/hashicorp/vault@v1.9.0 requires github.com/hashicorp/vault/api/auth/approle@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000 ``` ``` go get github.com/hashicorp/vault@v1.8.5 go: downloading github.com/hashicorp/go-secure-stdlib/base62 v0.1.1 go: downloading github.com/hashicorp/go-secure-stdlib/password v0.1.1 go: downloading github.com/evanphx/json-patch/v5 v5.5.0 go: downloading github.com/hashicorp/go-secure-stdlib/tlsutil v0.1.1 github.com/hashicorp/vault imports github.com/hashicorp/vault/command imports github.com/hashicorp/vault/builtin/credential/aws imports github.com/hashicorp/vault/sdk/helper/awsutil: cannot find module providing package github.com/hashicorp/vault/sdk/helper/awsutil ```
|
Need explanations 😬 Genre dans le readme peut être ? histoire de comprendre comment les gens sont censés utilisés ce repo avec les 3 packages |
|
Oui c'est prévu, je voulais déjà valider avec toi |
jawher
approved these changes
Jan 11, 2022
elagree
approved these changes
Jan 11, 2022
|
A description would be great ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.