Skip to content

Conversation

atengler
Copy link

@atengler atengler commented Oct 5, 2018

  • add FormTemplateCollector client to get form source template (YAML, Jinja2, RST) and render it into JSON form schema with pre-generated secrets and HTML documentation
  • add endpoints to expose the FormTemplateCollector

@atengler atengler requested a review from katyafervent October 5, 2018 23:33
requirements.txt Outdated
@@ -0,0 +1,11 @@
cryptography==2.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do not use requirements txt and keep everything in setup.py and use pipenv. You can generate requireents.txt with pipenv lock -r if you want

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipenv doesn't really work for me and python setup.py install fails for me, because of the pygerrit installation fails with PBR error, so I wanted an alternative. But the PBR error can be worked around by setting PBR_VERSION=1.0.1-dev1 before running python setup.py install so I can remove the requirements.txt I guess. Just pointing out why I wanted to have one

@atengler atengler changed the title ModelForm endpoints - WIP ModelForm endpoints Oct 8, 2018
@katyafervent katyafervent merged commit 1bbd4a6 into Mirantis:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants