Add SALT API client #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dis-xcom
reviewed
Apr 28, 2017
| """docstring for CommonServicesManager""" | ||
|
|
||
| __config = None | ||
| __underlay = None | ||
| _config = None |
There was a problem hiding this comment.
Please keep these variables private. If you need to use them in ExecuteCommandsMixin , please pass 'underlay' and 'config' objects to ExecuteCommandsMixin.init and store them as private for this class
| @@ -26,7 +26,7 @@ | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope='function') | |||
| def openstack_actions(config, underlay): | |||
| def openstack_actions(config, underlay, salt_actions): | |||
There was a problem hiding this comment.
It's better to use 'salt_deployed' fixture instead just 'salt_actions' to ensure that salt is actually deployed. Fixture 'salt_deployed' returns the same object as salt_actions.
dis-xcom
added a commit
that referenced
this pull request
May 31, 2018
If the job is queued while waiting for the free executors, then the method was getting the wrong build_id belonging to the previous job, for instance it will return build_id=28 in this example: №29 (pending—Build #28 is already in progress (ETA:17 min)) №28 [In progress] May 31, 2018 6:07 PM * Add 'timeout' parameter (default 600sec) in run_build() to wait until the queued build is started * Add pooling the queue until the build is started, get the build number assigned to build in queue object * Add 'verbose' parameter (default False) to show the reason from Jenkins why the build is not started yet, for example: pending the job 'deploy_openstack' : Build #22 is already in progress (ETA:1 min 48 sec) pending the job 'deploy_openstack' : Build #22 is already in progress (ETA:1 min 18 sec) pending the job 'deploy_openstack' : Build #22 is already in progress (ETA:48 sec) * Rename the parameter 'print_job_output' to 'verbose' in the method wait_end_of_build() to have the common parameter naming. Change-Id: Id49b5b45a8127e769b89860b19424081f37f6f38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.