Refactor operation and translation value_type to always have a value and handle string/empty/null etc #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and handle string/empty/null etc
simonprev
force-pushed
the
refactor/value-type-langue
branch
from
360af86
to
1c16dc2
Compare
remi
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And various other UI fixes and resolver refactor 🙈
Now every translation is tagged with the right value.
string,empty,null,booleanNext steps will be to tag boolean, number when parsing in the difference
Langue’s parsersFurther steps include the separation of the structure of the value. from the type. Like array, plural types. These "states" will need to be in another field because a field in an array can have a value_type.