Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of ember-cli-node-assets #18

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Get rid of ember-cli-node-assets #18

merged 2 commits into from
Apr 25, 2018

Conversation

charlesdemers
Copy link
Member

ember-cli-node-assets isn’t needed anymore since ember-cli can import scripts from node_modules now.

I also removed lint exceptions because the node version required for the project supports const

simonprev
simonprev approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@simonprev simonprev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@simonprev simonprev merged commit 2ac74d0 into mirego:master Apr 25, 2018
@charlesdemers charlesdemers deleted the cleanup/remove-ember-cli-node-assets branch April 25, 2018 03:38
remi
remi reviewed Apr 25, 2018
View reviewed changes
Copy link
Member

@remi remi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi remi remi left review comments

@simonprev simonprev simonprev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesdemers @remi @simonprev