Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit “expert” term in request comment #15

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

remi
Copy link
Member

@remi remi commented Apr 18, 2019

We had a small inconsistency between how we represent “expert” and “learner” reviewers.

Before

%SelectedUser{metadata: %{stack: "graphql"}, type: "stack", username: "foo"}
%SelectedUser{metadata: %{stack: "graphql"}, type: "learner", username: "foo"}

After

%SelectedUser{metadata: %{stack: "graphql"}, type: "expert", username: "foo"}
%SelectedUser{metadata: %{stack: "graphql"}, type: "learner", username: "foo"}

@remi remi requested a review from garno April 18, 2019 13:49
@mirego-builds
Copy link

🦀 Requesting reviewers for this pull request:

  • @garno (contributor with 5 commits in the last 90 days and 5 commits overall)
  • @simonprev (reviewer for the elixir stack)

@remi remi merged commit d13958c into master Apr 19, 2019
@remi remi deleted the feature/add-explicit-expert-term-in-request-comment branch April 19, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants