Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flexibility in absent username extraction #28

Merged

Conversation

remi
Copy link
Member

@remi remi commented Sep 16, 2021

📖 Description and reason

Recently, Absence.io changed how it exposes absences as calendar events. Previously, each event title was formatted like this:

Out of Office - $NAME

but now the absence type is used as the prefix instead of a generic one, so we have:

Vacation - $NAME
Maternity Leave - $NAME
etc.

We want to support all of them 🙂

👷 Work done

Tasks

  • Remove the hardcoded Out of Office prefix and use only the last part of the title as the name
  • Update test suite

🦀 Dispatch

#dispatch/elixir

@mirego-builds
Copy link

🦀 Requesting reviewers for this pull request:

  • @JoeyBG (contributor with 0 commits in the last 90 days and 1 commits overall)
  • @MathieuLegault1 (reviewer for the elixir stack)

Copy link

@thermech thermech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@remi remi force-pushed the feature/add-more-flexibility-for-absence-name-extraction branch from 2c1483b to 5809068 Compare September 16, 2021 15:48
@remi remi merged commit 65f81e2 into master Sep 16, 2021
@remi remi deleted the feature/add-more-flexibility-for-absence-name-extraction branch September 16, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants