Add possibility to mute learners for a repo #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi
reviewed
Feb 13, 2019
remi
reviewed
Feb 13, 2019
gcauchon
reviewed
Feb 13, 2019
garno
force-pushed
the
feature/mute-learners
branch
2 times, most recently
from
e19727e
to
06768c9
Compare
remi
approved these changes
Feb 13, 2019
bducharme
reviewed
Feb 13, 2019
Since we open source this bad boy, we don’t want to expose who is learning what outside of Mirego. So, we can now pass the `mute_learners` argument to disable learners assignation.
garno
force-pushed
the
feature/mute-learners
branch
from
06768c9
to
d5d0fc3
Compare
remi
reviewed
Feb 13, 2019
Co-Authored-By: garno <sam@garno.me>
gcauchon
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we open source Dispatch, it will be used on open source projects. Those projects might be backed by a corporation that doesn’t want to expose which person is learning what.
We can now disable
learnersby usingdisable_learners=truewithin the webhook’s query string.✌️