Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling GitHub API with empty data #8

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Avoid calling GitHub API with empty data #8

merged 1 commit into from
Mar 5, 2019

Conversation

remi
Copy link
Member

@remi remi commented Mar 5, 2019

We now avoid requesting reviewers and posting a request comment with an empty list.

Closes #7

@mirego-builds
Copy link

🦀 Requesting reviewers for this pull request:

  • @garno (contributor with 5 commits in the last 90 days and 5 commits overall)
  • @simonprev (reviewer for the elixir stack)

@remi remi merged commit fc02325 into master Mar 5, 2019
@remi remi deleted the feature/do-not-call-github-api-with-empty-lists branch March 5, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garno garno garno approved these changes

@gingman gingman gingman approved these changes

@simonprev simonprev simonprev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@remi @mirego-builds @garno @gingman @simonprev