-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conflict with ppx_sexp_conv >= v0.11.1 #107
Comments
Dear @copy:
I'm sure this will lead to invalid metadata (in the META file of X.509) due to ppx_sexp_conv introducing run-time dependencies. This is hard to observe (by using opam) since
I'm not exactly sure what you mean. I hope my description above sheds some light into why X.509 (and tls) are restricted to I'll merge #109 and release X.509 for compatibility with newer ppx_sexp_conv. I hope this works fine for you. |
fixed in #109 |
You're right about this. Originally I was under the impression that simply adding
I was referring to the original issue here: mirleft/ocaml-nocrypto#143, which is not related to Nocrypto's META files but to its build system (see mirleft/ocaml-nocrypto@ee7305f and mirleft/ocaml-nocrypto@a9da8a8). I simply stated that x509 doesn't suffer from this problem.
Very much appreciated. |
As per ocaml/opam-repository#11898 (comment) ppx_sexp_conv>=v0.11.1 does not have a dependency on Base any more, so the compatible versions can be changed from
ppx_sexp_conv < v0.11.0
toppx_sexp_conv != v0.11.0
.I checked that x509 is compilable with newer versions of ppx_sexp_conv (and doesn't suffer from the same bug that nocrypto suffers from).
Related: mirleft/ocaml-tls#379
The text was updated successfully, but these errors were encountered: