Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conflict with ppx_sexp_conv >= v0.11.1 #107

Closed
copy opened this issue May 16, 2018 · 3 comments
Closed

Remove conflict with ppx_sexp_conv >= v0.11.1 #107

copy opened this issue May 16, 2018 · 3 comments

Comments

@copy
Copy link

copy commented May 16, 2018

As per ocaml/opam-repository#11898 (comment) ppx_sexp_conv>=v0.11.1 does not have a dependency on Base any more, so the compatible versions can be changed from ppx_sexp_conv < v0.11.0 to ppx_sexp_conv != v0.11.0.

I checked that x509 is compilable with newer versions of ppx_sexp_conv (and doesn't suffer from the same bug that nocrypto suffers from).

Related: mirleft/ocaml-tls#379

@hannesm
Copy link
Member

hannesm commented Aug 24, 2018

Dear @copy:

so the compatible versions can be changed from ppx_sexp_conv < v0.11.0 to ppx_sexp_conv != v0.11.0

I'm sure this will lead to invalid metadata (in the META file of X.509) due to ppx_sexp_conv introducing run-time dependencies. This is hard to observe (by using opam) since nocrypto nowadays already adds the required depedencies into their META file and shadows the insufficient data in X.509 META file.

I checked that x509 is compilable with newer versions of ppx_sexp_conv (and doesn't suffer from the same bug that nocrypto suffers from).

I'm not exactly sure what you mean. I hope my description above sheds some light into why X.509 (and tls) are restricted to ppx_sexp_conv {< "v0.11.0"} at the moment.

I'll merge #109 and release X.509 for compatibility with newer ppx_sexp_conv. I hope this works fine for you.

@hannesm
Copy link
Member

hannesm commented Aug 24, 2018

fixed in #109

@hannesm hannesm closed this as completed Aug 24, 2018
@copy
Copy link
Author

copy commented Aug 24, 2018

I'm sure this will lead to invalid metadata (in the META file of X.509) due to ppx_sexp_conv introducing run-time dependencies. This is hard to observe (by using opam) since nocrypto nowadays already adds the required depedencies into their META file and shadows the insufficient data in X.509 META file.

You're right about this. Originally I was under the impression that simply adding ppx_sexp_conv to the META file would work for both ppx_sexp_conv<v0.11.0andppx_sexp_conv>=v0.11.0, but that doesn't seem to be the case.

I'm not exactly sure what you mean.

I was referring to the original issue here: mirleft/ocaml-nocrypto#143, which is not related to Nocrypto's META files but to its build system (see mirleft/ocaml-nocrypto@ee7305f and mirleft/ocaml-nocrypto@a9da8a8). I simply stated that x509 doesn't suffer from this problem.

I'll merge #109 and release X.509 for compatibility with newer ppx_sexp_conv.

Very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants