Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for inotify for vim editor #4

Merged
merged 1 commit into from
May 6, 2019
Merged

Fix for inotify for vim editor #4

merged 1 commit into from
May 6, 2019

Conversation

ont
Copy link
Contributor

@ont ont commented May 5, 2019

Some editors like vim do writes through temporary file. That temporary
file then renamed to original one.

Some editors like vim do writes through temporary file. That temporary
file then renamed to original one.
@mirmik mirmik merged commit b45d3e8 into mirmik:master May 6, 2019
@mirmik
Copy link
Owner

mirmik commented May 6, 2019

good job

@mirmik
Copy link
Owner

mirmik commented May 6, 2019

Unfortunately, there may be problems with access permissions rights to some files in the directory. I couldn’t figure out how to solve this quickly, and so for now I’ve rolled back the commit. 66d9ed7

@mirmik
Copy link
Owner

mirmik commented May 6, 2019

In general, our friend @sevikkk, who ported zencad to mac, was forced to replace inotify with a mechanism for periodic file checks (since there is no inotify on mac). I thought this mechanism should be legalized, since it will not only be cross platform with OS, but also with respect to editors.

@sevikkk
Copy link

sevikkk commented May 6, 2019

There are some cross platform libs for things like this, but I'm not sure we actually ned this for tracking of single file.

And for more general problem when there are imports and so on, there are ready to go solutions, like https://github.com/fyrestone/pydevd_reload. And probably there is a sense to just use them and do not reinvent the wheel.

@mirmik
Copy link
Owner

mirmik commented May 6, 2019

It would be nice to add import dependency.
I will study this library.

mirmik added a commit that referenced this pull request Oct 5, 2019
Fix for inotify for vim editor
mirmik added a commit that referenced this pull request Feb 16, 2021
Fix for inotify for vim editor

Former-commit-id: 06982eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants