Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape literal left braces in regular expressions #26

Open
trwyant opened this issue May 21, 2016 · 0 comments
Open

Escape literal left braces in regular expressions #26

trwyant opened this issue May 21, 2016 · 0 comments

Comments

@trwyant
Copy link

trwyant commented May 21, 2016

With Perl 5.25.1, unescaped literal left braces in regular expressions become an error. This is part of a deprecation that was begun in 5.22. This issue turned up in the "speedup" script, not in XML::Twig proper, so the warnings (when they were warnings) were only visible when running Makefile.PL.

A pull request is in preparation.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Nov 28, 2016
Upstream changes:
3.52 - 2016-11-23  - minor maintenance release

- fixed: the previous fix was buggy...

3.51 - 2016-11-23  - minor maintenance release

- fixed: failing tests when XML::XPathEngine and XML::XPath not available

3.50 - 2016-11-22  - minor maintenance release

- added: the no_xxe option to XML::Twig::new, which causes the parse
  to fail if external entities are used (to prevent malicious XML to
  access the filesystem).
  See RT#118097 https://rt.cpan.org/Public/Bug/Display.html?id=118097

- fixed: warning (and soon error) due to unescaped literal left braces
  in regular expressions in the code generating Twig.pm
  reported by trwyant
  mirod/xmltwig#26

- fixed: (partial fix) implement getNamespaces in XML::Twig::XPath::Elt
  the expression doesn't crash the code, but doesn't return anything
  interesting (yet)
  reported by Nathan Glenn
  mirod/xmltwig#12

- fixed: various spelling mistakes
  mirod/xmltwig#24
  thanks to James McCoy for the patch

- git repo cleanup, thanks to mjg17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant