Use hs.hotkey.modal for modals, a bugfix, and some code cleanup
#9
Conversation
- titleCase, round, frontmost… to locals (we don't need to pollute the global namespace) - some indentation and documentation fixes - and some minor cleanup to satisfy the lauc linter (line length, trailing whitespace)
and retire watchers & etc. that are no longer needed. Extend double tap behaviour to move & resize states.
…width/height didn't quite register; first entering the modal, then performing the action seems to fix this.
|
Hello Matt! I checked this but with the modal the window can't be moved unless you repeatedly press the arrows. Also I noticed in your changed the window move and resize are bound to just arrows, but people use also WASD or HJKL as arrows. I'll review changes and bugfix, but I don't think I can merge this as is |
|
Those are both excellent points, and I think I've just fixed them both. |
|
@matthewfallshaw Maybe I installed your branch incorrectly, but I'm not seeing the local hyper = {"ctrl", "alt", "cmd"}
local hyperShift = {"ctrl", "alt", "cmd", "shift"}
hs.loadSpoon("MiroWindowsManager")
hs.window.animationDuration = 0.1
spoon.MiroWindowsManager:bindHotkeys({
up = {hyper, "k"},
right = {hyper, "l"},
down = {hyper, "j"},
left = {hyper, "h"},
fullscreen = {hyper, "return"},
center = {hyper, "c"},
move = {hyper, "v"},
resize = {hyper, "d"}
}) |
|
... aaaaannndd I hadn't pulled since switching my submodule over to your fork. Sorry for the noise on this thread. I've tested your changes and they work great for me! This seems to solve the issue I was seeing in the previous PR! |
| @@ -201,6 +207,18 @@ function obj:resize(growth) | |||
|
|
|||
| fr = fr:intersect(frontmostScreen():frame()) -- avoid sizing out of bounds | |||
|
|
|||
| if self.stickySides then | |||
There was a problem hiding this comment.
ooooo, nice! I would love to see this get merged so I can get back on the main branch. cc: @miromannino
|
@miromannino I'm still on this PR/fork for the functionality in it. I can't speak to the Lua code, but the functionality would be a great addition. Please consider merging or at least helping @matthewfallshaw make changes that you would like to see. Thanks! |
|
Ok I'll review this soon , the last time there were bugs and I never had a chance to see @matthewfallshaw fixes, sorry for that! Yes I would like to merge if everything is stable. For now @rjhilgefort please tell me if you find any bug so we can address it before merging to main |
|
@miromannino Thank you!! This Spoon you've created is one of my favorite utilities on my Mac and I greatly appreciate the time you spend on it. Sorry to be a bother! I've been running this fork for something like 2 months now and I haven't seen anything to mention. I'll continue to keep an eye out. |
|
I know I actually cannot think to work without it. :) |
Major changes: - add `move` and `grow` methods to move and grow (or shrink) windows - fullscreen starts by centering the window, then proceeds through the sequence Minor changes: - update hs.grid when obj.GRID changes, making obj:init() unnecessary - forget obj._pressed state after a second (with move & grow changes I found myself wanting to shift modifier keys without releasing them, this means I can just pause) - refactor code to make it easier (for me) to understand - tweak the documentation a little
(as it does going or growing)
…` on direction change).
- titleCase, round, frontmost… to locals (we don't need to pollute the global namespace) - some indentation and documentation fixes - and some minor cleanup to satisfy the lauc linter (line length, trailing whitespace)
and retire watchers & etc. that are no longer needed. Extend double tap behaviour to move & resize states.
…width/height didn't quite register; first entering the modal, then performing the action seems to fix this.
* 'master' of github.com:matthewfallshaw/miro-windows-manager: (26 commits) Sticky sides (optionally stick to a bound side when shrinking windows). HS docs are broken and can't do word wrapping. [sad face] minor: cleanup bugfix: support holding move keys to keep moving or growing bugfix: support non-arrow keys as moving keys bugfix: sometimes double tapping opposing directions to grow to full width/height didn't quite register; first entering the modal, then performing the action seems to fix this. bugfix: don't let our fullscreen originalPositionStore get garbagecollected. minor: cleanup, docs & logging Use `hs.hotkey.modal` for `← + →` and `↑ + ↓` double taps, and retire watchers & etc. that are no longer needed. Extend double tap behaviour to move & resize states. bugfix: don't force windows from higher or lefter screens onto the primary screen Use hs.hotkey.modal for modal move & resize housekeeping - titleCase, round, frontmost… to locals (we don't need to pollute the global namespace) - some indentation and documentation fixes - and some minor cleanup to satisfy the lauc linter (line length, trailing whitespace) fixes and refactoring resize fullscreen completed fullscreen fixes Update MiroWindowsManager.spoon/init.lua first cleanup and refactorings `cancel_press` as `releasedfn` (keyup) for moves (prevents `growFully` on direction change). Add Center method ...
|
@miromannino this really seems worth merging in. Doing so would also provide something akin to what #15 is about, removing the need to merge that one. |
|
I'm currently on this branch and everything seems smooth as butter, at least from a cursory look. |
|
Perfect! I am glad to know! I will then definitely merge! I just need to review @matthewfallshaw code before submitting. Thanks again @matthewfallshaw again for changes! |
|
@miromannino here I am for my yearly "thank you" message for your window manager and my personal +1 for this PR (which I've been using for one year now without encountering any glitch or issue). Do you still plan on merging this? |
Bugfix:
Refactoring:
hs.hotkey.modalfor move and resize modalsChange:
@miromannino ,
Thank you again for your stellar work on this Spoon. I like your keyboard interface for Move & Resize Modes much more than I liked the one I created in my last pull request.
If you don't like the addition of jumping to full width/height after tapping opposite directions in Move & Resize Modes, remove
; growFullyModals[move]:enter()from line 564,; growFullyModals[mapR[resize]]:enter()from line 583, then remove lines 584, 580 and 565.