Refactor ClientGenerator class to use private fields

[Minister944]

ClientGenerator:

• Changed query to _query.
• Changed variables to _variables.
• Changed response to _response.
• Changed data to _data.

Fixes #277

[rafalp]

Rebase on main and add changelog entry.

[rafalp]

Looking at the diff this change introduced, I am wondering how much extra work would it be to instead detect when one of args is query and only then use _query. Likewise do same for _variables, _result and _data. 🤔

[Minister944]

Looking at the diff this change introduced, I am wondering how much extra work would it be to instead detect when one of args is query and only then use _query. Likewise do same for _variables, _result and _data. 🤔

we would have to pass arguments or set flags to code-generating functions just to determine whether to add _
this does not look complicated, but makes the code less readable and increases the level of difficulty of debugging. what would be the purpose of this?

[leandrolerena]

I can confirm that the fix solves the issue with variable shadowing/overwriting, the client works as expected.

[rafalp]

@Minister944

what would be the purpose of this?

To don't hit people with pull requests that change 9k places when they update their codegen version.

Lets see how much complexity this change would actually introduce.

[Minister944]

we solved it in a different way #281
I am closing this pr