Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_executable_schema resolvers arg should accept dict of dicts or list of dicts of dicts #11

Closed
rafalp opened this issue Aug 2, 2018 · 0 comments · Fixed by #30
Closed
Assignees
Labels
help wanted Extra attention is needed roadmap Feature that we want to have included
Milestone

Comments

@rafalp
Copy link
Contributor

rafalp commented Aug 2, 2018

The make_executable_schema utility should optionally take list of dicts of dicts (AKA "resolvers map"), this would allow larger projects to easily split and compose resolvers as needed:

from ariadne import make_executable_schema

from products.graphql import resolvers as products_resolvers
from users.graphql import resolvers as users_resolvers


typedefs = "..."
resolvers = [products_resolvers, users_resolvers]

schema = make_executable_schema(typedefs, resolvers)

This task will likely require #13 to be done first, so we are 100% certain that all resolver mappings are dicts.

@rafalp rafalp added the roadmap Feature that we want to have included label Aug 2, 2018
@rafalp rafalp added this to the 0.1 milestone Aug 7, 2018
@rafalp rafalp self-assigned this Aug 20, 2018
@rafalp rafalp removed their assignment Aug 27, 2018
@rafalp rafalp added the help wanted Extra attention is needed label Aug 27, 2018
@salwator salwator self-assigned this Aug 28, 2018
@rafalp rafalp closed this as completed in #30 Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed roadmap Feature that we want to have included
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants