Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop property assignment to constants #2612

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

alexlamsl
Copy link
Collaborator

Only difference is with ember.prod.js under -mc passes=2 (or more)

master

http://builds.emberjs.com/tags/v2.11.0/ember.prod.js
- parse: 0.750s
- rename: 0.515s
- compress: 5.922s
- scope: 0.156s
- mangle: 0.313s
- properties: 0.000s
- output: 0.234s
- total: 7.890s

Original: 1852178 bytes
Uglified: 525313 bytes
GZipped:  128593 bytes
SHA1 sum: 5604c9f51b22ae0d38f652ed429e0e179c6261af

This PR

http://builds.emberjs.com/tags/v2.11.0/ember.prod.js
- parse: 0.734s
- rename: 0.594s
- compress: 5.828s
- scope: 0.141s
- mangle: 0.312s
- properties: 0.000s
- output: 0.313s
- total: 7.922s

Original: 1852178 bytes
Uglified: 525190 bytes
GZipped:  128563 bytes
SHA1 sum: 429e537397492cd76cdaf500f12f3f49d900ea5f

@alexlamsl alexlamsl merged commit 0b0eac1 into mishoo:master Dec 18, 2017
@alexlamsl alexlamsl deleted the const-prop-assign branch December 18, 2017 04:08
@alexlamsl
Copy link
Collaborator Author

Not to let test/ufuzz.js steals the spotlight, this PR was corrected by test/jetstream.js 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant