-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve original sourceContents from inSourceMap #566
Conversation
Fixes mishoo#152 Somehow addresses mishoo#145 by preserving the original sources in the inSourceMap (if they are there)
Hmm, so there travis ci error seems to be completely unrelated…, right? Apart from that, 👍 |
Yep, looks so! |
Thanks for this PR. Surprised it hasn't been merged, it seems high-value, low-risk. |
Yes… would be tremendously helpful if merged and released… |
Resolved via ad18689 |
Merged someone else's copy paste of this pull request, interesting... |
I preferred the code style of the other pull request. Think of it whatever pleases you. |
I'll think this project is sadly ignorant about how to support good contributions. There's no way to know what style you prefer if you (1) don't document it anywhere, (2) silently ignore PRs like this for three months and then close them without explanation. It's your repo. But if you want to actually get bugs closed faster, maybe it would help to grow the community a bit instead of driving potential help away. |
In case I came across more harsh than intended: I'm not objecting to taking another PR. That just happens, and it's fine. I'm pointing out that the tone of the response in this thread comes across poorly. |
There are even older PRs that have been “ignored”, and I'm the one to blame for that. Sorry about it. @rvanvelzen might have simply stumbled across the other one first, and merged it — this happens; I don't see a reason for your frustration, now that the problem is finally fixed. Again, I apologize for the delays and I honestly thank Richard for taking the trouble to curate the issues list. |
Fixes #563
Fixes #152
Somehow addresses #145 by preserving the original sources in the inSourceMap (if they are there)
This way you can do multiple transformations the source map e.g.
typescript
/coffeescript
->js
->browserify
->exorcist
->uglify