Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Feature #39

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

GUI Feature #39

wants to merge 11 commits into from

Conversation

jwnorm
Copy link
Contributor

@jwnorm jwnorm commented Jul 22, 2022

GUI Feature

Adds a new file gui.py, which contains the function get_user_input. This is combined with a gooey decorator in order to add a GUI to the make_hills function. This does not replace the CLI, but instead offers an alternative for users who may be more comfortable clicking than typing.

There are a few open items I would like to have resolved at some point:

  • Expand optional parameters that are exposed in the GUI
  • Convert in_field and out_field parameters to a dropdown menu based on the stop_data_csv that is supplied
  • Bake in better default start_analysis_dt and end_analysis_dt inferred from the min/max dates present in in_field and out_field, respectively

@jwnorm jwnorm changed the base branch from master to develop July 22, 2022 18:58
@misken
Copy link
Owner

misken commented Jul 22, 2022

I'm going to pull your gui branch into a new jwnorm-gui branch on my end and play around with it. One thing I realized is that this will be a great interoperability test/challenge as I'm using Ubuntu and you are using Windows. This is a bridge that had to be crossed at some point, and this is a great test case.

@jwnorm
Copy link
Contributor Author

jwnorm commented Jul 25, 2022

Did not even think of that, great idea.

One issue I can think off the bat is that I explicitly target hillmaker.exe in my gui.py file (you can find it in the Gooey decorator near the top of the script). Would the script file that is generated via a pip install in a Linux environment be .sh format?

@jwnorm jwnorm mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants