Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #1

Merged
merged 5 commits into from
Feb 25, 2021
Merged

Housekeeping #1

merged 5 commits into from
Feb 25, 2021

Conversation

jugmac00
Copy link
Contributor

  • add support for Python 3.7 - 3.9
  • flake8 also setup.py and tests
  • fix path to isort
  • fix syntax error in REAMDE.rst
  • add example for basic usage

@jugmac00
Copy link
Contributor Author

I ran the test suite on my dev machine via tox - all green.

I saw there was not much action in the last three years.

Do you still use RML and this package?

I consider to start using it, as I maintain an application which uses reportlabs RML, but accepts user input via HTML, and the current converter has its issues.

@jugmac00
Copy link
Contributor Author

ping @misli - as I saw you do not watch this repo.

If you are not interested in contributions, please say so.

Thanks!

@misli
Copy link
Owner

misli commented Feb 25, 2021

Hi Jürgen,
I use it to convert HTML snippet from WYSIWYG editor (custom text on invoice for example) to RML snippet.
Since it already does all I need, I don't do any updates. But any improvements are being welcome.

@misli misli merged commit 11abb83 into misli:master Feb 25, 2021
@jugmac00 jugmac00 deleted the housekeeping branch February 25, 2021 13:49
@jugmac00
Copy link
Contributor Author

Thanks for your quick answer! Sounds good.

I need some more testing before I switch the old converter to html2rml, but looks good.

@jugmac00
Copy link
Contributor Author

@misli I have a very similar use case, where some colleagues can fill some custom text for a delivery note.

Which WYSIWIG editor are you using?

I have problems when my colleagues copy text from e.g. Word and the formatting gets pasted into the WYSIWIG editor.

@misli
Copy link
Owner

misli commented Feb 26, 2021

In my case it's a django-CMS based application. (That's why it also provides Django template filter for rendering.) Therefore I use ckeditor from djangocms-text-ckeditor.

Example usage in Django model:
https://github.com/leprikon-cz/leprikon/blob/master/leprikon/models/agreements.py#L11

Example usage in RML template:
https://github.com/leprikon-cz/leprikon/blob/master/leprikon/templates/leprikon/registration_pdf/subject.rml#L290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants