Adding Persian localization into the project #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EtienneLem |
|
Sure thing! New locale PRs will be reviewed and merged soon. |
|
Thanks for the contribution. Am I right that Persian is a RTL (right-to-left) script? Should it be reflected in the UI where the categories checkpoint would be right aligned? |
|
Thanks @EtienneLem |
EtienneLem
force-pushed
the
feature/persian-localization
branch
from
5872894
to
8c9137d
Compare
|
No worries, got it covered! با تشکر! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added necessary changes required for having Persian localization in project.
Could you please consider reviewing my work.
Thank you.