Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misskey-js): Play関連の権限を追加(APIコンソールで発行可能に) #11360

Merged
merged 19 commits into from
Aug 21, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jul 23, 2023

What

  • Play関連の権限をmisskey-jsに追加
  • Play関連の権限を持つAPIトークンをAPIコンソールで発行可能に(APIコンソールはmisskey-jsの権限リストを直接参照しているため)

Why

Play関連の権限がAPIコンソールで発行できず不便だったため
(参考: https://github.com/natureofmad/misskey-wordle)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #11360 (3ebc667) into develop (2939e81) will increase coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11360      +/-   ##
===========================================
+ Coverage    78.66%   78.93%   +0.26%     
===========================================
  Files          923      176     -747     
  Lines        97492    22913   -74579     
  Branches      7741      520    -7221     
===========================================
- Hits         76695    18086   -58609     
+ Misses       20797     4827   -15970     

see 749 files with indirect coverage changes

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review July 23, 2023 06:37
@github-actions github-actions bot requested review from syuilo and tamaina July 23, 2023 06:37
@kakkokari-gtyih
Copy link
Contributor Author

CHANGELOG.md のコンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo syuilo merged commit b60ff1f into misskey-dev:develop Aug 21, 2023
16 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 21, 2023

👍

@kakkokari-gtyih kakkokari-gtyih deleted the mkjs-add-flash branch August 21, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants