-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): 動きのあるMFM無効時にレインボー文字が出ない問題を修正 #11361
Merged
syuilo
merged 18 commits into
misskey-dev:develop
from
kakkokari-gtyih:mfm-rainbow-fallback
Aug 21, 2023
Merged
fix(frontend): 動きのあるMFM無効時にレインボー文字が出ない問題を修正 #11361
syuilo
merged 18 commits into
misskey-dev:develop
from
kakkokari-gtyih:mfm-rainbow-fallback
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #11361 +/- ##
===========================================
- Coverage 78.66% 78.64% -0.03%
===========================================
Files 923 922 -1
Lines 97492 97392 -100
Branches 7741 7741
===========================================
- Hits 76695 76590 -105
- Misses 20797 20802 +5
|
CHANGELOG.md のコンフリクト解消 |
コンフリクト解消 |
コンフリクト解消 |
コンフリクト解消 |
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
当該書式を使用している場合に、ノート作者が意図したように伝わらない可能性があるため
Additional info (optional)
現時点で「動きのあるMFMを有効にする」が有効になっているときでも、
$[fg.color= ]
などで文字色を変更しないとレインボーになりません。この問題も一緒に修復したほうが良いかも?Checklist