fix(backend): テストが死んでいるのを修正 #12738
Merged
fix(backend): テストが死んでいるのを修正 #12738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12738 +/- ##
===========================================
- Coverage 81.91% 79.76% -2.15%
===========================================
Files 180 956 +776
Lines 27475 108745 +81270
Branches 509 8366 +7857
===========================================
+ Hits 22505 86743 +64238
- Misses 4970 22002 +17032 ☔ View full report in Codecov by Sentry. |
Merged
|
🙏🙏🙏🙏🙏 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* fix test * fix test * fix test * fix test * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
develop本線でバックエンドのテストが死んでいるのを修正しました。
アップロード・ダウンロードのテストで使用するURLに間違いがあったこと、
テスト用のモジュール内で循環参照の対応ができていなかったことが原因でした。
Why
CIの妨げになっているため
Additional info (optional)
ローカルでpassすること、自分のforkのActionsでpassすることを確認
Checklist