fix: Make tensorflow an optional dependency #8986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvisser
changed the title
nvisser
changed the title
rinsuki
approved these changes
Jul 12, 2022
|
nice |
|
なんか完全な解決になっていない気がする（実行時に@tensorflow/tfjsがないと言われてコケる、@tensorflow/tfjsをoptionalDependenciesに追加すると今度はlongがないと言われてあきらめた） |
エラーメッセージの全文を掲載していただけませんか？私のARM64マシンでは、依存関係のインストールとビルドは問題なく行われました。 |
grainrigi
added a commit
to grainrigi/misskey
that referenced
this pull request
Nov 20, 2022
Fixes misskey-dev#9202 Since '@tensorflow/tfjs-node' is moved into optionalDependencies in misskey-dev#8986, '@tensorflow/tfjs', a peer dependency of 'nsfwjs', won't be installed when optionalDeps are skipped. This was causing missing module error during the server boot. To fix this, we add '@tensorflow/tfjs' as a normal dependency. This won't break non tensorflow capable platform since this package does not require any prebuilt binaries to be installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Misskey will not build on platforms that tensorflow does not support (arm64 etc.) This change makes tensorflow an optional dependency, together with #8984 Misskey can build and run on unsupported platforms.
Why
Misskey will not build on platforms that tensorflow does not support (arm64 etc.)
Additional info (optional)