-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sw): Typecheck the service worker #9314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the service worker build never typechecks, since esbuild and typescript-eslint don't do such job. esbuild: https://esbuild.github.io/content-types/#typescript >However, esbuild does not do any type checking so you will still need to run tsc -noEmit in parallel with esbuild to check types. This is not something esbuild does itself. typescript-eslint: https://typescript-eslint.io/linting/troubleshooting#why-dont-i-see-typescript-errors-in-my-eslint-output >TypeScript's compiler (or whatever your build chain may be) is specifically designed and built to validate the correctness of your codebase. Our tooling does not reproduce the errors that TypeScript provides, because doing so would slow down the lint run [1], and duplicate the errors that TypeScript already outputs for you. Adding this step adds tons of TS errors 😱
tamaina
changed the title
Typecheck the service worker
refactor(sw): Typecheck the service worker
Dec 12, 2022
👍 |
Jeder321
pushed a commit
to Jeder321/misskey
that referenced
this pull request
Dec 18, 2022
This implements the upstream changes from misskey-dev#9314 but updated to our version of ESLint. Also updates TypeScript to 4.9.4 for all packages.
lunaisnotaboy
added a commit
to mint-lgbt/fedimint
that referenced
this pull request
Mar 29, 2023
commit 3489c8ac3aa0a5f9a12b7a31d74e91ea5d04159d Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 23:24:05 2023 +0100 fix: loading config commit 06ef7522187ab846c1cc2b547305ba645d60967b Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 23:00:34 2023 +0100 adjust readme commit 44f02fa3ec4f5ad35c6d4f38f47430b6224418d6 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 22:22:00 2023 +0100 update documents for new release commit d655bda30c8336fbfe752d34858c833b860c9f66 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 22:15:28 2023 +0100 add foundkey floofer commit 839daea8877114a2d1b4116553dd8fefb0360986 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 18:08:19 2023 +0100 remove mi-white.png asset commit 41c42f96f0464ead2ef1bfb862be6085dd2fa340 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 17:57:52 2023 +0100 BREAKING server: disable deliver rate limit by default The deliver rate limit seems to cause a lot of performance problems, presumably because of the overhead the rate limit has. It also does not really make sense to rate limit outgoing because we are requesting from different servers anyway. fixes https://akkoma.dev/FoundKeyGang/FoundKey/issues/190 Changelog: Changed commit 9a6bb8be7de3acee4815339cdeb12d1a925505a5 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 17:56:15 2023 +0100 server: default config items on load commit 1adf88b09013d79113418f681f15d1edb5b46a16 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 16:44:30 2023 +0100 fixup: OpenGraph data generation This is a fixup for commits 39fb7e594624957ec2e0f15ec2ec6332901587af and be30e70344cb2862b4397ce0a5927dfda0014c2d. commit 28c11ca7afb7e47c3fe55180eda3ebd8c083992b Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 15:58:13 2023 +0100 refactor isPureRenote to foundkey-js commit 9458045c8f25f749f235d27374d9810e14669c26 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 15:32:25 2023 +0100 server: refactor note/renote rendering to separate file commit a8c0e1f8278c4df364d539626948fd797a1f128f Author: Mia Herkt <mia@0x0.st> Date: Sat Feb 4 11:00:52 2023 +0100 fix migration for note.url unique index fixes https://akkoma.dev/FoundKeyGang/FoundKey/issues/331 Co-authored-by: Johann150 <johann.galle@protonmail.com> commit 63665e8bd1fa76c19f778c31e174fd94a727e9bd Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 00:21:13 2023 +0100 client: replace array concat with Array.prototype.flat commit 85a68a5eee14b8e638d2f9fabacf5ea3f2298cdf Author: Johann150 <johann.galle@protonmail.com> Date: Sat Feb 4 00:13:43 2023 +0100 activitypub: properly render CW only quotes Changelog: Fixed commit 0bb4a6af50bad03a8a26737572c668253af27c49 Author: Johann150 <johann.galle@protonmail.com> Date: Fri Feb 3 23:29:31 2023 +0100 client: fix quotes with only a CW Changelog: Fixed commit a45908c1cbfb5049c8593f68c2bf52299d0cc58f Author: Johann150 <johann.galle@protonmail.com> Date: Fri Feb 3 23:12:12 2023 +0100 client: check quoteId for canPost computation fixes https://akkoma.dev/FoundKeyGang/FoundKey/issues/334 Changelog: Fixed commit ca257d7d0c283b99b6a0c95cec6905862c3ae679 Author: Johann150 <johann.galle@protonmail.com> Date: Fri Feb 3 11:48:46 2023 +0100 server: remove application level websocket ping Changelog: Removed commit 30c26abde7bdd76d497da5fc7149452586240c3a Author: Johann150 <johann.galle@protonmail.com> Date: Fri Feb 3 11:47:54 2023 +0100 server: add websocket ping mechanism fixes https://akkoma.dev/FoundKeyGang/FoundKey/issues/336 Changelog: Fixed commit 17324e1e94f0f3d0d34fd6fd87a8a4d011b620db Author: Johann150 <johann.galle@protonmail.com> Date: Fri Feb 3 00:27:33 2023 +0100 server: add unique constraint for registry items fixes https://akkoma.dev/FoundKeyGang/FoundKey/issues/335 commit 8b98c9f2f4d3c6f077b6e448d30c4b566cfec0e8 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Feb 2 23:24:26 2023 +0100 server: remove unused 'domain' column commit be30e70344cb2862b4397ce0a5927dfda0014c2d Author: Johann150 <johann.galle@protonmail.com> Date: Wed Feb 1 23:18:10 2023 +0100 server: add more OpenGraph data, remove custom misskey meta tags Changelog: Changed commit 39fb7e594624957ec2e0f15ec2ec6332901587af Author: Johann150 <johann.galle@protonmail.com> Date: Wed Feb 1 11:34:09 2023 +0100 server: improve OpenGraph data for note attachments With this change, not all files will be proclaimed to be image files. Only images, videos and audio files will be represented with OpenGraph data. More properties for these files will also be represented, e.g. image alt text. However, if the note has a CW or any of the files are marked sensitive, none of the files will be used. The users profile picture will not be used any more. Changelog: Changed commit 75b14124f2d1ca6dc56ed6393f866b9240aa79fc Author: Johann150 <johann.galle@protonmail.com> Date: Wed Feb 1 11:30:53 2023 +0100 server: improve variable naming commit 7480e27c0c3a08ba0af941d77ed56f398b6d067e Author: Johann150 <johann.galle@protonmail.com> Date: Wed Feb 1 11:27:27 2023 +0100 server: remove twitter links from HTML templates Since the twitter integration has been removed, this will never be true and can therefore be removed. commit 953de3e4b2ee7f27ca221ff6b52d78a90b39ed5c Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 30 19:36:22 2023 +0100 adjust mailmap commit 2d32bc33d746bac9968d302e997437de00c791b8 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 30 19:23:12 2023 +0100 server: fix error for invalid URLs in profile fields Co-authored-by: Chloe Kudryavtsev <code@code.bunkerlabs.net> commit bb3ec8bafe5d16eea061929271f72032c8aeb6f3 Author: Chloe Kudryavtsev <code@toast.bunkerlabs.net> Date: Mon Jan 30 14:59:24 2023 +0100 Revert "server: fix user deletion race condition" This reverts commit cc83cbe523169bc749f719bc7b5869e511584c11, reversing changes made to 8abd3ebec700aac42fa91994277a2a24ab5a598a. This changeset contains: * multiple type errors * a foreign key incompatibility * breaks outgoing note federation (in at least two ways) commit 6fd80816fa7a45899facb0ff80c450405b301d71 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 29 14:29:58 2023 +0100 client: remove unused property from MFM component commit cc83cbe523169bc749f719bc7b5869e511584c11 Merge: 8abd3ebec b245d39b6 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 29 12:53:29 2023 +0100 server: fix user deletion race condition Changelog: Fixed Ref: https://github.com/misskey-dev/misskey/issues/7506 commit 8abd3ebec700aac42fa91994277a2a24ab5a598a Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 29 12:38:38 2023 +0100 client: remove notification forwarding to service worker This was an interim measure, but now that push notifications are always enabled, this should not be necessary any more and the service worker should receive all notifications automatically. commit 36031c083a02346c9cf340d0b26d0ac43116f4c0 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 26 13:25:13 2023 +0100 docs: adjust parameters for v2 methods other than POST commit 05f8172ce99a4c80c87946d77c0de584e1f98fb4 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 26 08:36:32 2023 +0100 docs: describe /ap/ endpoints commit 151053897ded058d88d83230a0c16e269b5163f7 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 26 08:35:42 2023 +0100 server: lower rate limit for deletion activities Changelog: Changed commit 95a9027a6675142c641c2db5e297be95a9ea209c Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 26 08:34:06 2023 +0100 docs: show rate limit information Changelog: Added commit 57cf6c71633c824ae168c7a5287a09dbfd018ea6 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 26 08:25:19 2023 +0100 server: indicate Retry-After when rate limiting This refactors the rate limiting code to throw an ApiError directly. Changelog: Added commit 9b76c805ec5d109e5cdfc4097c8c268afa1d3b58 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 25 22:14:53 2023 +0100 fix: DriveFile folder & user undefined instead of null when unrequested commit 21b20920c2c6dc28abbd7bf1358c548534a8fd97 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 13:06:25 2023 +0100 docs: use endpoint stability to mark endpoints deprecated commit e7644eb7572d96534b02ed733eeb7fdc386f12b5 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 23 19:58:07 2023 +0100 server: add index to human readable URL commit 66ec8756240f84db5fc63818fa2c9a21603f9dd6 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 23 18:05:17 2023 +0100 server: also search human readable URL Changelog: Fixed commit 78f5ca3792fcb46a79a2edbf29da5e195ad190ab Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 22 21:47:02 2023 +0100 server: fix empty array in quote detection commit c792e4199cc4d4bac59b42ef25ea5485861e3d90 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 22 21:42:49 2023 +0100 server: add missing return in extractQuoteUrl commit afa4094050ddb798f835f66995a7e8d737178d7c Merge: e3fd371f4 c4b595278 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 22 20:18:57 2023 +0100 BREAKING: Remove galleries Existing gallery posts will be made into normal notes. If a user has gallery posts, a clip with all gallery posts will be created. Changelog: Removed commit c4b5952788976cc50ac0281e8f1f21c3264ccbd1 Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 17 21:17:00 2023 +0100 migrate galleries to notes/clips commit e3fd371f4af0dcf97456fecceaf56b823c9eb04b Merge: 7170b8672 5893a44ff Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 17 21:49:27 2023 +0100 Implement FEP-e232 qoutes Changelog: Added commit 5893a44ff58b1cd6ea5eb032ff7bc950a30d0eab Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 5 22:19:34 2023 +0100 server: parse quote tag syntax Ref: FEP-e232 commit 9bdf24d3a56b67b694b4ee01890b262d97ea6a24 Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jun 14 13:18:54 2022 +0200 enhance: add tag for quotes Ref: FEP-e232 commit 2bbb85b47209bb01d9b822d536a9f96028a4161d Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 16 18:53:57 2023 +0100 backend: remove galleries commit 70fb1e9a5cf6633e8b77794b561c9fa529355e51 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 16 18:47:29 2023 +0100 foundkey-js: remove galleries commit 48163872eddf803e36aea5221e33c29ba9d4fb51 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 16 18:30:45 2023 +0100 client: remove galleries commit 7170b86724243716f269ba86b4372a68030a4f7b Author: Johann150 <johann.galle@protonmail.com> Date: Sat Jan 14 13:22:09 2023 +0100 fixup: websocket data parsing + logger commit 96e6187e835224ae41ad8c27d3748a218b647425 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Jan 14 12:03:50 2023 +0100 docs: admin password reset commit 3d2cfc075a36e0bbefa7ec54bdd624120caf062d Author: Johann150 <johann.galle@protonmail.com> Date: Fri Jan 13 21:55:14 2023 +0100 fixup: actually check whether the group joining is from the user commit 83373e0c513a8163c015649e467234d36f9a3915 Author: Francis Dinh <normandy@biribiri.dev> Date: Thu Jan 12 17:08:50 2023 -0500 split build task into parallel and non-parallel versions This allows FoundKey to be built on systems with 2GB or less RAM without swapping or running out of memory. commit 11518d2f262921b3d77c4880b44ff8e20b9d6176 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 12 20:53:39 2023 +0100 add documentation about moderation commit f9c360d59f09051bb1c03031cb3ba9a890c5965e Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 12 20:09:24 2023 +0100 client: remove duplicated check Since the enclosing block already checks for moderator, this check is unnecessary. commit 2a8792fe07dae55c595b453224d21ea12227c29d Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 12 19:40:36 2023 +0100 client: add button to delete all files for moderators The functionality was already there, there was just no button to access it for some reason. closes https://akkoma.dev/FoundKeyGang/FoundKey/issues/243 Changelog: Added commit b8963a0119043cbe748d30424d161b285cf912f2 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 12 19:27:16 2023 +0100 update yarn.lock commit 1319dc93d9df09715253c90ec086200fa0fd7cc9 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 11 22:16:01 2023 +0100 server: switch websocket to ws commit 80e28513781d63fe23d3d4392698f4a429f1874b Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 11 20:58:38 2023 +0100 fixup: remove trailing comma in JSON commit 14b48fb07c4a80cba15a50beb6c4da7e89d889ef Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 11 20:31:55 2023 +0100 client: remove unused dependencies commit 5e2a9224f3b2e3eebd5218f6a1d95846227c2575 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 11 19:50:29 2023 +0100 add "fungus" as alias to emoji list commit 624628d5829e1793ab58379d486df366b3611ade Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 11 19:45:18 2023 +0100 client: remove unused websocket libraries The websocket functionality is provided by foundkey-js so there is no need to import any websocket libraries. commit e68eeba7a6b10f0dbedcb6fb24d94e0c1466c3a1 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 11 19:12:58 2023 +0100 fixup: remove admin/delete-account endpoint from foundkey-js This is a fixup for commit c7ab8839dc78f131827974e351bfdd534d82fae3. commit ee2fa2e0be06e61b7b8e6bbb07ba2d4e78a2073c Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 10 20:35:03 2023 +0100 fixup: import commit 57d1af1117a91bee9b50115add48b0fc36bb160b Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 10 20:30:47 2023 +0100 remove default export in streaming API commit 8c2b7e20b25dd5073e70afc2f3b899dbfab9aecb Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 9 20:44:01 2023 +0100 translating comments, cleanup commit fdf30f60e6289bddcf13ce91a4db326fcdcde102 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 9 20:43:12 2023 +0100 server: remove SQL boolean comparisons commit b245d39b6e317ad6422f98e7d36fa1d74dc88296 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 8 18:53:54 2023 +0100 server: delete records of fully deleted users commit 80f72e21cd5772ba841cbd2dbf510432d16945da Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 8 18:50:35 2023 +0100 server: track deletion completion commit 85e985d13fe8c84e06c4aeea3c31ee92ef3cef30 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 8 17:57:36 2023 +0100 server: change data structure to track deletion completion commit 4fe288f17c2e416bba59e9499ecea41f89e888e2 Author: Johann150 <johann.galle@protonmail.com> Date: Fri Dec 30 13:45:19 2022 +0100 server: rewrite user status queries in SQL commit cd26e3a35c6232f8001cf79117c1863447e8af3c Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 8 19:34:03 2023 +0100 fixup: missing parenthesis commit c7ab8839dc78f131827974e351bfdd534d82fae3 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Jan 7 19:30:06 2023 +0100 BREAKING: remove admin/delete-account, change admin/accounts/delete You should use the API endpoint admin/accounts/delete. It has the same parameter and the same behaviour. The admin/accounts/delete endpoint now requries administrator privileges instead of just moderator privileges. Changelog: Removed commit 1eda1760d12ca6671c3f14ac6662b6433a5f8986 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Jan 7 19:28:18 2023 +0100 server: refactor to always use deleteAccount service This should reduce code duplication around how deletion of an actor is handled. commit 8772181b6f5b0fbf4705cec0bf7fca31baf4837f Author: Johann150 <johann.galle@protonmail.com> Date: Sat Jan 7 14:48:35 2023 +0100 server: refactor remote host check to validateActor Instead of checking that an actor is not from the local host separately, it seems like a good idea to do it in the central place that is supposed to validate an actor. commit 8f21275dd51d1e58c983ffc68d55a8122601a70b Author: Norm <normandy@biribiri.dev> Date: Sat Jan 7 01:50:25 2023 +0000 roadmap: Update links to reference labels instead of projects commit 5102d0bc2efd7b9995f1d3f552b60f392f694133 Author: Francis Dinh <normandy@biribiri.dev> Date: Fri Jan 6 02:51:44 2023 -0500 chore: remove unused user_group_invite table Based on `1558257926829-UserGroupInvite.js` but switched `up` and `down` migrations around. Closes #314 commit cdba5447e62ecee4ebda2b7c2764bf6cba5e1298 Author: Puniko <me@absturztaube.ch> Date: Mon Dec 26 09:09:11 2022 +0100 server: remove joins to avatar and banners in children endpoint Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/303 commit 4bb814adfc4d96ddc67819bdcee94d0bf1a344d8 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 5 20:55:03 2023 +0100 client: add space between endpoint and code in error message commit 35e9d7f9584a9f8d9c38464697cf6dd60298acb6 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 5 20:50:25 2023 +0100 client: fix null i18n interpolation values Fixed the occurence that was reported in <https://akkoma.dev/FoundKeyGang/FoundKey/issues/317> along with a similar one. Fixes <https://akkoma.dev/FoundKeyGang/FoundKey/issues/317> Also changed the i18n code so this should not happen any more in the general case. commit a0c2cf328e083713033b967ad43ad3912e32f2ac Author: Johann150 <johann.galle@protonmail.com> Date: Thu Jan 5 20:03:38 2023 +0100 server: fix redirected fetch Don't throw a StatusError on an intended redirect. commit 334368f6e22872a38835e5712ff4939e789a3691 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 4 21:39:33 2023 +0100 fix: allow to pick higher visibility than chosen before If you selected a lower visibility that one would then be used as the parent visibility. Instead it is necessary to use two separate variables, one for parent and one for the preselected visibility. commit 3efa7046bd3d2b427d2fbbdf02ddcaf2de8cc206 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 4 20:59:31 2023 +0100 meta: don't type check dependencies commit 48f8fb97df0bc28e1235fbd6dd4146861a8e1c63 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 4 20:56:06 2023 +0100 activitypub: use quoteUri instead of quoteUrl It's not quite Mastodon, but still, I said they'd use a different approach... Changelog: Changed commit 0230f819e22a5b6d1c4c5060f41949ad87fe5040 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Jan 4 19:07:40 2023 +0100 fixup: wrong negation This is a fixup for commit 417d252e9d701f95e809ebd21a33b701bc239c0b. commit e58c940d6fbfd4f8ef59a468bb2af86941a4923d Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Jan 3 21:53:02 2023 -0500 meta: Bump copyright year commit 08af6fda371bc102deacc3b037d9e4c35ad6c8fd Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 3 22:18:01 2023 +0100 fix some type errors commit 0c8a3cfeec2b8b36c9db30b8ab57c26c20936cfc Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 3 03:51:38 2023 +0100 server: fix lints commit 8bc366fde01700ebffb1afb803f6f7925ff09419 Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 3 02:47:58 2023 +0100 server: fix comma-dangle lint commit 417d252e9d701f95e809ebd21a33b701bc239c0b Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 3 02:42:42 2023 +0100 server: fix custom lint typeorm-prefer-count commit b54e07caec3d2960918921880afb1561599bcff2 Author: Johann150 <johann.galle@protonmail.com> Date: Tue Jan 3 02:41:53 2023 +0100 enhance typeorm-prefer-count lint rule commit e0560dbe9ef5d60d11fa29185a0413dfe35e89ae Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 21:51:13 2023 +0100 client: dont display tooltip if software name unknown Changelog: Fixed commit 5b898c6c82d3d104be8df359852c368972bf7e51 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 21:39:49 2023 +0100 chore: update yarn files commit 6010884e623de91c03fffd780d89edfe8aa3c126 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 21:07:56 2023 +0100 cleanup: translate japanese, use SECOND constant commit b423d23cf69601a1e873d4a4f4e0905c86037e54 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 21:07:02 2023 +0100 server: fix custom lint typeorm-prefer-count commit 29714d1ae0c63e4e213304d951efb86c9e898199 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 20:58:33 2023 +0100 add custom eslint rule to prefer countBy over findBy commit 7bf4d4426a57831a613f5c255518388661957f72 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 14:43:27 2023 +0100 use count instead of find to check existence commit d28931bf00568d99708d6ee4e86cb5962c558c11 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 12:43:41 2023 +0100 server: remove dateUTC function commit 2a46719f312e7ec7f02509383240e40dad18705c Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 12:23:47 2023 +0100 server: set file permissions after copy This explicitly sets the file permissions to allow everyone to read files since apparently multer sometimes doesn't set the permissions we expect. Ref: https://akkoma.dev/FoundKeyGang/FoundKey/issues/202 Changelog: Fixed commit 7f564431bee3d2476acb5c45ef0df11b07863d89 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Jan 2 00:11:35 2023 +0100 server: fixup sql Fixup to 0b7c9095bf96254a4ac0b4488b223088bd078612. commit 0fbd7fa4925a09f77ef16f5b433422502a6b67de Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 1 23:32:01 2023 +0100 client: fix 500 error in notifications closes https://akkoma.dev/FoundKeyGang/FoundKey/issues/73 Changelog: Fixed commit 3aaa9facc6c7ff71d42a213448a7b18ac6a2cf2a Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 1 23:30:43 2023 +0100 translate japanese to english commit 8f09b05e7c56e7868a5c1d63e2ccab36a7d6782c Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 1 22:27:25 2023 +0100 chore: remove reversi database tables Changelog: Fixed commit 8b0b7ff525e64cdeb7f3ee98f6b9804f893e4fe6 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 1 22:11:19 2023 +0100 server: change default value for api/admin/show-users origin param Changed from "local" to "combined" to fix a bug when the hostname is set but origin is not. Changelog: Changed commit 0b7c9095bf96254a4ac0b4488b223088bd078612 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 1 21:22:53 2023 +0100 server: don't return users twice in search commit 338e898f5691532891f2229da7f4c5efd4de7598 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Jan 1 21:02:55 2023 +0100 client: disable unavailable visibilities commit 3a9d2836307bc2a4d303717ed0bb6eac5f315a06 Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 21:37:33 2022 +0100 client: make mod patterns display when seeking on stopped track commit ed27f61a4d376b4d1257af5aea81b9c40d10338a Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 29 21:34:57 2022 +0100 client: add mod tracker Squashed commit of the following: commit 54f0b67b25bc6064b5c0ab3982e20943859aff76 Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 21:27:15 2022 +0100 use nextTick instead of setTimeout commit 6998cae7e3a706b00c1b63320750dab279f13e3d Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 21:14:55 2022 +0100 my absolute terrible fix to the unhide issue commit 79f546d1509185c315a5db7e12985e01ed430b08 Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 21:01:35 2022 +0100 stop player on hide/unhide commit 6b7f13e8ef48d74edb92441144051e4225b27f71 Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 10:36:59 2022 +0100 make webkit style range slider the same commit 8a267c5cdc5c1e98d6dd1e038571d92d01985a98 Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 01:16:18 2022 +0100 restyling range inputs commit c39e1671b2957326ff91746da44091d728f58e82 Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 00:57:47 2022 +0100 make module seekable commit c1762f27ae2e4d342ede88018f777c75b8b31d4a Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 00:14:35 2022 +0100 remove accesskey attribs commit 08f75a01f1c2359799e4c2ec734a391d3abfc07c Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 00:12:23 2022 +0100 v-else on play button commit 9302a9faaa5a75c33314befb3f8e0f414e9d886b Author: Puniko <me@absturztaube.ch> Date: Thu Dec 29 00:08:19 2022 +0100 replace filter with some commit bffd15daedf55f7623d6ebd777a12384274b89d6 Author: Puniko <me@absturztaube.ch> Date: Wed Dec 28 09:13:20 2022 +0100 add chiptune2 and libopenmpt into COPYING commit 794298c21c6fe09909136d141fd2a6b83eb64a89 Author: Puniko <me@absturztaube.ch> Date: Tue Dec 27 15:32:43 2022 +0100 little cleanup commit f383aec1cd5a9f8a44539d9f802dee2d1332f64c Author: Puniko <me@absturztaube.ch> Date: Tue Dec 27 15:23:25 2022 +0100 repeat only once and proper handling of track ending commit fdaa9614c993de306789ecafc38d781d350fe1ab Author: Puniko <me@absturztaube.ch> Date: Tue Dec 27 14:52:20 2022 +0100 prevent losing connection when downloading module commit 6c5723c795a3610558111f5d0cd6f39dcfd06965 Author: Puniko <me@absturztaube.ch> Date: Tue Dec 27 14:45:59 2022 +0100 colours!!! 🌈 commit dba4f0a4a909b956d928bfb7e4f0321291a096e0 Author: Puniko <me@absturztaube.ch> Date: Tue Dec 27 13:01:06 2022 +0100 replace with i18n commit 4234dfbdbc7f9b73fe07348af1fe2590db4e811d Author: Puniko <me@absturztaube.ch> Date: Mon Dec 26 15:47:10 2022 +0100 retab commit 0cc1ea8c3ec14fde81936ec3c9eed4d06ad52d95 Author: Puniko <me@absturztaube.ch> Date: Mon Dec 26 15:19:28 2022 +0100 include libopenmpt tracker to foundkey commit c2437c696a5dabb8581fd81f7852cdd6091fe00f Author: Puniko <me@absturztaube.ch> Date: Mon Dec 26 12:08:49 2022 +0100 add libopenmpt Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/306 Changelog: Added commit ed9d4023d41bba7c4ac53a1a3422246feed37de2 Author: Chloe Kudryavtsev <toast+git@toast.cafe> Date: Thu Dec 29 20:13:47 2022 +0000 backend: add argon2 support Passwords will be automatically re-hashed on sign-in. All new password hashes will be argon2 by default. This uses argon2id and is not configurable. In the very unlikely case someone has more specific needs, a fork is recommended. ChangeLog: Added Co-authored-by: Chloe Kudryavtsev <code@toast.bunkerlabs.net> Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/308 commit 76a8e000a361d334b03abc00b31b4215c773a947 Author: Johann150 <johann.galle@protonmail.com> Date: Tue Dec 27 21:47:34 2022 +0100 client: only catch erroneous key errors in i18n.ts commit a673647fba673626a70b66ca8465140a6ef6e070 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Dec 26 18:52:16 2022 +0100 server: remove avatarColor and bannerColor properties According to comments next to those properties, they were kept for backward compatibility. However they were always being set to null. Changelog: Removed commit eea2eb491953c8bd43ca4a325351e165f40b3585 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 25 16:07:25 2022 +0100 use Promise.all instead of separate promises commit 114d416de0b5b5f3635503a44ed9e4454102b7f7 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 25 15:49:06 2022 +0100 server: refactor password hashing & comparison to module For easier replacement should the hash algorithm ever be changed. commit c2372315f7c9365ea9c650bebe2da690dd0f5e80 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 25 15:33:46 2022 +0100 server: improve error messages Refactor Error's to ApiError's. Changelog: Changed commit 09bc3cf95a40dbe320d752cc41ff4b65d9adb41b Merge: 8e12b9a33 de3cdb583 Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 24 18:40:44 2022 -0500 activitypub: Do block checks more globally Changelog: Fixed Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/299 commit de3cdb5833a04b274d2117cf1d48801533b4bae1 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 25 00:01:58 2022 +0100 activitypub: block check for resolving collections commit a732cdc1ad994d7f901c4787a6f45805ac57a28e Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 24 11:59:20 2022 -0500 activitypub: perform block check in performOneActivity commit a8f82050c85dac01614940d710c7762371272ead Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 24 11:58:49 2022 -0500 activitypub: perform resolver block check on objects as well commit 8e12b9a33ee41a5a0f6b85da4408ddd7068ad3f0 Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 24 15:01:32 2022 -0500 server: restore original comment for skippedInstances commit 6583d0c43d9af262f4a33679f0490bdfb4863420 Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 24 14:56:39 2022 -0500 server: pass in resolved meta table to shouldBlockInstance This should make it more friendly to use in places where the meta table has already been resolved for other reasons. commit c02a03168dd3a992ee588e34917881d2b0fee090 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 24 13:48:58 2022 +0100 fixup tooltip: use this instead of self commit 85419326f868291036681cc9ddfbbc545d37f77d Author: Johann150 <johann.galle@protonmail.com> Date: Fri Dec 23 13:55:15 2022 +0100 server: use prelude function instead of separate function commit eaa11647f0d005e349f440f1cfabf8c2ad3b075a Author: Johann150 <johann.galle@protonmail.com> Date: Fri Dec 23 13:54:12 2022 +0100 server: rewrite drive usage queries in raw SQL commit 61a2db49dfcb22481c77d819f57bee8909ea68a5 Author: Johann150 <johann.galle@protonmail.com> Date: Fri Dec 23 13:38:29 2022 +0100 server: always use user id for calcDriveUsageOf commit 79ddbafd0dae01556a08814b7a808a78b1e4d53b Merge: 0e1459e5c e8e82dac8 Author: Johann150 <johann.galle@protonmail.com> Date: Fri Dec 23 11:06:07 2022 +0100 client: fix tooltips not closing closes https://akkoma.dev/FoundKeyGang/FoundKey/issues/120 Changelog: Fixed commit 0e1459e5cfbb5007495a35eb2a2a417984d65c1a Merge: 969024484 4db25e4b1 Author: Norm <normandy@biribiri.dev> Date: Fri Dec 23 02:06:31 2022 +0000 Merge pull request 'server: refactor follow request functions to be named exports' (#296) from refactor/follow-requests into main Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/296 commit e8e82dac8253acc2b2666abf89b9f9b07f03c589 Author: Johann150 <johann.galle@protonmail.com> Date: Fri Dec 23 02:30:57 2022 +0100 fixup: confusing commas commit 9690244848fc67017fdbf26cf7c9951d0b2cc341 Author: Francis Dinh <normandy@biribiri.dev> Date: Thu Dec 22 17:52:30 2022 -0500 server: add return type for all follow reject funcs commit 4db25e4b1fb0126de796effae73670bf78091ab5 Author: Francis Dinh <normandy@biribiri.dev> Date: Thu Dec 22 16:50:46 2022 -0500 server: add doc for cancelFollowRequest commit 549302e9c02c6f9e1dc60828425f637b78d453d8 Author: Francis Dinh <normandy@biribiri.dev> Date: Thu Dec 22 16:54:55 2022 -0500 server: add doc for createFollowRequest commit a3354904af6c706dace83c789e29afb1170fb9f1 Author: Francis Dinh <normandy@biribiri.dev> Date: Thu Dec 22 16:45:25 2022 -0500 server: use named export for createFollowRequest commit 28f65bebfcea728a4c1755eb4621048cb6de08a3 Author: Francis Dinh <normandy@biribiri.dev> Date: Thu Dec 22 16:43:38 2022 -0500 server: use named export for cancelFollowRequest commit 2204adc6576b3bd7abe1de667ac124e4f3a745b3 Author: Francis Dinh <normandy@biribiri.dev> Date: Thu Dec 22 16:41:27 2022 -0500 server: use named export for acceptAllFollowRequests commit b11e4053db5b73f793029acaf2daecc3ef2ef27b Author: Francis Dinh <normandy@biribiri.dev> Date: Thu Dec 22 16:41:06 2022 -0500 server: use named export for acceptFollowRequest commit e2ef80070894a6834e2e6f1f61b739dcbcac766b Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 22 14:46:21 2022 +0100 server: dont use replace for file types No point in using replace if we already know which character we want to replace. commit a7048f17f7b1dc4374eae95b5b7f1a1239c05294 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 22 14:45:20 2022 +0100 server: simplify duplicated code commit ddf3e2c3dbdf41b6724e59d2cabb4cd4de13ba83 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 22 14:12:25 2022 +0100 client: refactor tooltip directive Using the beforeUnmount hook should hopefully improve issues with tooltips being left behind. commit 52afff800a9bfb3bcd32a05cd30fb53fef068dea Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 22 11:03:38 2022 +0100 server: start adding /api/v2 routes empty changelog commit Changelog: Added commit 33f0b24c56694f7c68bf26a148254e083ff0a08a Author: Johann150 <johann.galle@protonmail.com> Date: Tue Dec 13 18:36:54 2022 +0100 server: add v2 routes to notes endpoints commit 7685b925110bfa7ccb53e0dc54651a288ccd69aa Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Sun Sep 25 21:12:50 2022 +0200 improve fetching of endpoint arguments including support for route parameters (e.g. '/v2/note/:noteId' giving us a 'noteId' value) Co-authored-by: Johann150 <johann.galle@protonmail.com> commit 8276bd3bdc1e73ae008fdbf704f947b9a06b4b90 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Sun Sep 25 17:31:32 2022 +0200 generate OpenAPI spec for v2 endpoints commit aed27524709e6a60356e0eb3ec2bebc099002586 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Fri Sep 16 21:51:03 2022 +0200 server: make v2 meta endpoint support GET commit 4a3b91d658814742f36f65ae73f8ee0ee409feec Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Fri Sep 16 21:50:05 2022 +0200 server: add additional API v2 options to endpoints * improve type definitions for v2 method The method has to be lowercase because it is used as an index to get the respective method of the router. Co-authored-by: Johann150 <johann.galle@protonmail.com> commit 9317d2507883ad777d2ea27ca8bdb1b9223c43b5 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 21 21:46:45 2022 +0100 server: expire notifications after 3 months closes https://akkoma.dev/FoundKeyGang/FoundKey/issues/292 Changelog: Added commit fc36bb888031a60e6b30f31074b14404f3225c28 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 21 21:45:56 2022 +0100 server: reduce code duplication in check-expired queue job commit 711bb8be7d3c5219d6d45bfbfb7e5ba6c83d3f09 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 21 21:04:54 2022 +0100 fixup: add missing redirect argument commit 275136cf8b346004b24e581ff51147cadeb7d7c7 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 21 20:45:55 2022 +0100 allow redirects in API ap/* endpoints commit aa33708b909b99a4aefb83d66b65e2f43619ffb9 Author: Johann150 <johann.galle@protonmail.com> Date: Tue Dec 20 22:06:54 2022 +0100 server: handle redirects in signed get part of https://akkoma.dev/FoundKeyGang/FoundKey/issues/288 Changelog: Fixed commit d75e295ee815d9a1148bcc2f14e0d2c5c4f4f2db Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 20 00:10:17 2022 -0500 remove "your" from "read:reactions" Makes it consistent wiht the rest of the _permissions strings not using pronouns. commit 766ab1c4c4f0f9a6035a19ce309bdaa936e0df5b Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 20 00:07:35 2022 -0500 docs: readd missing "read:reactions" string commit 99c459a21a51d2e0fb0c2179de9cad22f910809c Author: Johann150 <johann.galle@protonmail.com> Date: Mon Dec 19 21:29:29 2022 +0100 server: better upload limit error Ref: https://akkoma.dev/FoundKeyGang/FoundKey/issues/293 commit bd68096ea993cf409b4cb7802a7ce74d7b24697b Author: Johann150 <johann.galle@protonmail.com> Date: Mon Dec 19 20:12:24 2022 +0100 server: refactor API error commit c4116691333e155bfd831e5fd61ad9714921f02b Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 18 20:42:05 2022 +0100 client: fix token-generate-window component commit 639fa74d43b8a5491806d6c9e60cd781d522d945 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 18 16:22:25 2022 +0100 client: restyle app token view commit 3bf7deb233a5b500f898a2bc0044a0b7ce807f85 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 18 00:50:02 2022 +0100 client: remove unused styling classes commit 25206332107ad9da74488b466e5821fda6202906 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 18 00:49:28 2022 +0100 client: move MFM animations to MFM component commit 4574db523a1b4c9aab6ab271a742c125a61050ec Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 18 00:11:32 2022 +0100 client: add default margin to FormSwitch and MkButton commit 263fb94f3f80054b69fa8ec2ef925a584cd7bcb4 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 17 23:32:25 2022 +0100 client: unify import names of form ui components commit 0e3321c106d6770f77e4a29b91ba4287b1b4f1c6 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 17 23:32:25 2022 +0100 client: unify import names of MkButton component commit 677ee537d1019482580aa538c067d300d139bb16 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 17 22:39:18 2022 +0100 client: remove unused component commit 1e539e6af5a7ba1221cfab97f33845ba1095c301 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 17 22:34:20 2022 +0100 client: add missing space see https://akkoma.dev/FoundKeyGang/FoundKey/issues/291 commit 0e5f7445603603c42e7268bbfe8e5d114c0d48b1 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 17 21:56:11 2022 +0100 client: 2fa is not its own settings page commit 8f782f8ce58ebbe0d7cbf01e5d00357099128001 Author: Norm <normandy@biribiri.dev> Date: Fri Dec 16 17:15:25 2022 +0000 scripts: convert to ESM and deduplicate (#290) This makes it a bit easier to add any new files that may need to be cleaned up in the future. Also allows us to use top-level await for the `yarn dev` task. Co-authored-by: Francis Dinh <normandy@biribiri.dev> Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/290 commit 6c7f1774e37dc22b87f10840de75c76200675e99 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 15 21:20:24 2022 +0100 server: fix thread mutes not applying to renotes Changelog: Fixed commit af43df15ca6f2f44b037e8a8fba23e4768ddd6b2 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 15 20:46:17 2022 +0100 reduce duplication in secureRndstr commit 5f83383ab85e1a9869838920ddebdb7246828db2 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 15 20:45:55 2022 +0100 fix import error in tests commit 8c759dde6c67c86871e002883aacc24531b309d8 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 15 19:44:55 2022 +0100 server: fix error about duplicate resolve commit 84d83d908a84fd5e6d9d05c6a14035e345ceaa72 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 15 17:52:19 2022 +0100 client: add button to unrenote Changelog: Added commit 16d091497ab7d6def9302f7c29b976aa300e5612 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 15 00:32:15 2022 +0100 server: use extractDbHost instead of toPuny, translate comments Also swapped logical or for nullish coalescing operator in some places. commit ef53ec276a49c2722a2f0677e587d9b43af239c7 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 15 00:31:23 2022 +0100 activitypub: simplify some URI/id related checks followup on previous commit commit 3582fd826017ee17196f68a1646100f385d3617c Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 15 00:29:39 2022 +0100 activitypub: centrally check id matches URL in resolver This makes some duplicated checks in models/note and models/person unnecessary. commit 6256ddbd3034db5888cecf041f38bdf500c90125 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 14 22:09:29 2022 +0100 client: remove unused variables commit 00fcc238f78268df424d1a54979fa2cf6c611953 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 14 22:08:27 2022 +0100 client: remove broken instance ticker from landing page commit 9f1670d5fd0494a9b75a8682211711cf10ef9c80 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 14 19:05:41 2022 +0100 server: fix default not found error image commit ff31b8b06d0863d07a0235af2601bd3a1c30d503 Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 16:35:52 2022 -0500 server: remove bios and cli The BIOS and CLI functionality were mainly for debugging purposes. If a user has to use those to resolve an issue with the server, that really should be fixed at the source instead. Closes: https://akkoma.dev/FoundKeyGang/FoundKey/issues/283 Changelog: Removed commit e317a771b35c967ba95fba7b1cbee90176afa443 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 14 18:52:36 2022 +0100 remove vscode config files commit 398ee6435bced800dbb51caf8bddcca8ea89da4f Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 14 18:21:24 2022 +0100 client: replace repo link with foundkey link commit ffff2ae5ef830a133bb7e3920892e99a4279410e Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 14 18:08:44 2022 +0100 server: fix missing import closes https://akkoma.dev/FoundKeyGang/FoundKey/issues/286 commit ccc8bf0289dc67d3b45dd84cb0def2733af9f95d Author: Johann150 <johann.galle@protonmail.com> Date: Tue Dec 13 23:09:20 2022 +0100 chore: fix more miscellaneous lints commit a231b36d59ea12bc54b030dec7ab0f7bb719c77b Author: Johann150 <johann.galle@protonmail.com> Date: Tue Dec 13 23:08:54 2022 +0100 chore: fix lint about unused variables in entities commit 8e9c65fab045f9f9e945a812a6f4de30b4f70d23 Author: Johann150 <johann.galle@protonmail.com> Date: Tue Dec 13 23:07:48 2022 +0100 chore: fix some import related lints commit 78a305131369bd0bf668ced0538cad501294c27c Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 16:46:29 2022 -0500 remove unneeded TODO commit 78717e85d363b80787a79c656767475bd2233e89 Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 16:45:04 2022 -0500 server: change JSON.parse/stringify to structuredClone structuredClone is more typesafe than using JSON.parse and JSON.stringify. Now that Node 18.x is the new baseline, this should be safe to use now. See https://developer.mozilla.org/en-US/docs/Web/API/structuredClone for details. commit a9d3cae511e8b4c77bc13e262d6920fe38fff2ab Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 16:31:15 2022 -0500 server: add return type to extractApMentions commit bd27b7ca3aa52c4d578782014c1356969f118ea1 Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 16:06:18 2022 -0500 server: add typing for renderFollowRelay commit e28a9eb8e87b65e2d700c8c268f2cf89b5060804 Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 16:02:06 2022 -0500 use tsc --noEmit for backend and client See https://github.com/misskey-dev/misskey/pull/9316 commit e5a4c5d2d0345093bf392902ff93b334ce6f08ff Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 15:57:26 2022 -0500 chore: update @typescript-eslint packages commit 6bba55c196fd3a42f4c5be996402bd6ff84711eb Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 15:42:08 2022 -0500 sw: add TypeScript type checking This implements the upstream changes from https://github.com/misskey-dev/misskey/pull/9314 but updated to our version of ESLint. Also updates TypeScript to 4.9.4 for all packages. commit 1d469f3c34712b87d66e4d32052a0e8c2f26e017 Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 15:12:29 2022 -0500 fix import typo commit 3f0228e14cd5f94cd36c429156b1e4246549497d Author: Francis Dinh <normandy@biribiri.dev> Date: Tue Dec 13 15:11:29 2022 -0500 server: use color-convert KEYWORD instead of extracting parameter type commit 73f81177b49c034a51d0662fad10467fd635ce85 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Dec 12 20:35:29 2022 +0100 foundkey-js: adjust type definition commit 6a26da35162f57a51991a63a624b9b32d627b84f Author: Johann150 <johann.galle@protonmail.com> Date: Mon Dec 12 20:00:05 2022 +0100 client: use configurable images commit 5ea744b1b28e6ab324355769b4a85f5926fd2149 Author: Johann150 <johann.galle@protonmail.com> Date: Mon Dec 12 19:26:55 2022 +0100 server: use configurable images commit ae6ba0530614411b542deb15232201b97d689b0d Author: Johann150 <johann.galle@protonmail.com> Date: Mon Dec 12 19:10:34 2022 +0100 add config for error images Changelog: Added commit 21069223e337ade718e1826f46119561b4d5dd69 Author: Sam Smucny <smucny.sam@gmail.com> Date: Thu Dec 8 00:57:23 2022 -0500 client: add tooltips to visibility icons Changelog: Changed commit d4d1e03479f948af7453a340878b3281e9d0faff Author: Johann150 <johann.galle@protonmail.com> Date: Tue Dec 13 20:35:46 2022 +0100 server: fix errors for replies and state when note doesnt exist commit 5513a3eb3a7a89f4fe6e4532c09e80024b1cf103 Author: Norm <normandy@biribiri.dev> Date: Sun Dec 11 23:16:05 2022 +0000 chore: update .gitattributes to reflect removed assets Since there's no longer any .afdesign/.psd files or the like, it's not necessary to have those in .gitattributes any longer. commit d5dd7c1ef5b019e871d19a06d3e114735cd0ad6b Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 11 20:52:52 2022 +0100 chore: remove more unused assets commit a80521b6a8cc345f835f81ae1c711b751a01088b Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 11 20:43:39 2022 +0100 chore: remove unused assets commit 030394b30d62f928409a6f9467a1128b445b7199 Author: Francis Dinh <normandy@biribiri.dev> Date: Sun Dec 11 14:42:55 2022 -0500 refactor: remove default export for boot commit 768d9bbdfba2530305211708c277420b447d3320 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 11 15:35:31 2022 +0100 refactor: remove default export for perform commit 3ef1a4b0f9d61f35e3cbdfde6562391b391f0f51 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 11 15:33:03 2022 +0100 refactor: remove default export for Resolver commit ae59ce51b02b97ed2a9509da190aa08480a5f46a Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 11 15:19:53 2022 +0100 refactor: remove default export for DbResolver commit 14a9b9bedd8c7c8e5d959d3edfee3c4656cf022b Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 11 15:14:59 2022 +0100 refactor: remove default export for request commit 985a13f47f71747bb3f89527d97318a7269b7cda Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 11 15:10:46 2022 +0100 refactor: remove default export for DeliverManager commit 3e46433edee94dddfadd0ca29589325d3854c71f Author: Norm <normandy@biribiri.dev> Date: Sun Dec 11 01:35:33 2022 +0000 docker: Ignore .woodpecker commit 507b328fdf649112c1896a5c1ffac462da73a10f Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 10 11:20:56 2022 +0100 activitypub: also forward resolver to resolveNote commit cf7449509f6bece184f676de41b4ed2a48f5eefd Author: Norm <normandy@biribiri.dev> Date: Sat Dec 10 05:23:22 2022 +0000 docs: add rfc links to oauth documentation commit f46ba3f7001dfa97414cf32b2192f0afc4289613 Merge: fde751df8 3cf673960 Author: Norm <normandy@biribiri.dev> Date: Sat Dec 10 04:10:44 2022 +0000 Merge pull request 'server: misc services code cleanup' (#275) from refactor/services into main Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/275 commit 3cf673960b8ef8bc577ad5626270ff2306d45401 Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 19:32:05 2022 -0500 server: Fix typing for user token Also fix a comment in the User model that wrongly states that the token is null if the user is local, when it's the opposite. commit cbfd866122dc9a0eaedb75959d5b714e7147d4f0 Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 17:10:54 2022 -0500 server: make fetcher key non-null commit b23a8dbaed21d5325674f7822b14082f4ea4633d Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 15:00:02 2022 -0500 server: translate comments commit 80a73a7510b2b30411988f516e94bba70fda694e Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 14:59:54 2022 -0500 server: remove unused imports from suspend-user.ts commit 3dec9a47f0651d25b0c4a9d4f7a095b72544a6d3 Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 14:59:08 2022 -0500 server: fix various type errors in services commit b8fb7a38ccc3c38a4a1c70428a7d7f1981f75682 Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 14:56:11 2022 -0500 server: improve Logger typing information and docs commit fdc682e810988fd02c963345b74f9a849102a19e Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 14:55:09 2022 -0500 server: remove sendEmailNotification The functions have their bodies completely comented out, which means they are doing nothing. commit fde751df8fd1da22fa8042134516bf72d090c463 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 8 19:06:55 2022 +0100 fix: properly supply resolver (2) commit 1faf1035f93fcf6c005db65bccab4599586be0fd Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 8 18:12:24 2022 +0100 server: handle users getting deleted somewhere else I don't know why but several jobs got stuck in my inbox queue because of errors like 'Could not find any entity of type "User" matching...'. commit e2ce599aca3db27db328ff7b6dfb70c6cd2d18b3 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Dec 8 18:12:05 2022 +0100 fix: properly supply resolver commit 73870e85cd1affff6b8c28743c00317ddeb2bdc3 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 7 23:22:19 2022 +0100 client: make headlines in queue widget links The headlines "inbox queue" and "deliver queue" are now links to the admin panel page about the queue. Changelog: Changed commit 350f21d95599b20a9aeaed4e0fb598b10a183ab5 Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 16:41:34 2022 -0500 server: fix typing for skippedInstances query commit 873e21f0905ae610bb007e156178cc7dcf5423d2 Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 16:27:53 2022 -0500 chore: update eslint commit 2afe54c1215b5fc278bab3e9d31373d0ada741fa Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 16:27:39 2022 -0500 eslint: allow backticks to avoid escaping single/double quotes commit 501cf834c86c0f40969d58ba13ab122664c96e67 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 7 21:55:39 2022 +0100 client: fix issue of search only working once closes https://akkoma.dev/FoundKeyGang/FoundKey/issues/274 Changelog: Fixed commit b66f7550abca12fa22ebc3b0071fb2b9eb0f3ff6 Author: Francis Dinh <normandy@biribiri.dev> Date: Wed Dec 7 13:39:21 2022 -0500 server: auto-fix lints commit 18664dbca3b62d2ad0869724308e2ae9f6afd45b Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 7 18:28:47 2022 +0100 server: add missing paren How did this not break yet? commit 0f3f42eb395300399b1e60f511ba596a2461ac39 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 7 18:03:29 2022 +0100 remove rndstr dependency This dependency was unused in the client. The use of it in the server can be replaced entirely by the secureRndstr function, with some slight modifications. That function could probably be refactored a bit more as well. commit 71b976ec96aa186bc77b0153ff4cfd68a3b2cc29 Merge: c1a51547a d3f1ad9a8 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Dec 7 17:16:14 2022 +0100 BREAKING: remove integrations The Discord, Github and Twitter integrations have been removed to reduce complexity and because they were only used on very few instances. Server admins that did disable this may want to revoke the OAuth client registrations for their instance that they made on the respective service. Changelog: Removed commit d3f1ad9a88f7f13805a642414948e1fd898267b6 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 23:18:27 2022 +0100 chore: remove unused packages commit 1aa3898db54cd9a7589943871a910771538280ac Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 23:12:45 2022 +0100 server: remove unused import commit 96c37445554ad270d4fc58214f296e85c5fceb04 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 23:00:32 2022 +0100 client: remove integration settings menu entry commit b023741f5026289edccdb11cdfab1e6871b238e0 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 23:00:08 2022 +0100 server: remove integrations field from user commit 87e1e658f2975fa07c1db7730b898047abaf4b63 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 22:03:34 2022 +0100 locales: remove integration-related locales commit 7e8d5c3b79ae37747c3c3561f42142c6a529d2f7 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 21:52:16 2022 +0100 foundkey-js: remove integration fields from instance type commit c785fbab6ef05afc8dc32f99c87cbee8dbb67b32 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 21:51:01 2022 +0100 client: remove integration signin options commit 547a1f81d4a629bb6c53420e14578cd1af631a73 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 21:50:34 2022 +0100 client: remove integration settings commit 95384d0bb28e7a0d50cd789ff0869fa318cca5c2 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 21:50:20 2022 +0100 client: remove integration admin settings commit 4cc5b734e774ff209faf94ffc1001934dc98cf91 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 21:49:19 2022 +0100 activitypub: remove integration fields from person and nodeinfo commit 5d328729991606cc9ed72d785d6ad362f786a0e0 Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 21:48:31 2022 +0100 server: remove integration API routes commit b4b1204f77e9736af0a754115d98b2ab720c013f Author: Andreas Nedbal <github-bf215181b5140522137b3d4f6b73544a@desu.email> Date: Tue Dec 6 21:47:59 2022 +0100 server: remove integration-related fields from meta commit c1a51547a911e407cd4cb91ed568a58a90d16ffb Author: Norm <normandy@biribiri.dev> Date: Mon Dec 5 17:55:38 2022 +0000 BREAKING: server: remove wildcard blocking and instead block subdomains (#269) Co-authored-by: Francis Dinh <normandy@biribiri.dev> Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/269 Changelog: Changed commit 4e74d26e45b0672cf8494fd4491d05456f2b45a2 Author: Chloe Kudryavtsev <code@toast.bunkerlabs.net> Date: Mon Dec 5 15:49:33 2022 +0100 backend: fix ratelimit typo Changelog: Fixed commit a421dd401ceb03e4937ba2b0fab925449b0790bf Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 4 00:29:45 2022 +0100 activitypub: refactor to always apply recursion limit Refactor to remove as many "new Resolver" as possible. commit c4211761e6c2d7124de026927a6ddb982266583e Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 3 23:45:10 2022 +0100 server: refactor resolveSelf to just return the webfinger href Since the href seems to be the only attribute that is used, and I didn't want to add a full type definition this was the easier option. commit 03b673165ff98c0c603046a648968f94e9383505 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Dec 3 23:07:33 2022 +0100 server: refactor "authUser" functions into separate file They did not really fit into the DbResolver because they may fetch data from remote instances even though DbResolver is only supposed to access the database. commit de18c8306d2fa1257c9561ba774bb9221ad7ee1a Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 4 19:05:02 2022 +0100 server: fix token-permissions migration The table that is affected here was not properly purged of old entries. It only holds data that is needed while a 3rd party authorization is in progress but not finished. The code that typeorm generated for this migration is a bit wonky because it should probably have dropped one column and created another one. But if we clear out all entries it should work regardless and I'm feeling lazy right now. :P commit 38df8dc7349a53dadaa22ae01ae8a5f80b5efe26 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 4 15:35:43 2022 +0100 client: set display name limit same as server Changelog: Fixed commit 11e4a8cb9bca25451b5f6bb61a2437ebda61a7c1 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 4 15:34:05 2022 +0100 remove erroneous space commit d1e0d79c1956e558f2ea9b88b8a88113c5e3e133 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 4 14:27:53 2022 +0100 client: unify different error dialogs Changelog: Fixed commit 946e862ecda537cd147dd95c73661aabcb1c626a Merge: 97052b1f6 7924d5d01 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 4 14:06:36 2022 +0100 server: implement OAuth 2.0 Authorization Code grant Changelog: Added Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/205 commit 97052b1f615780ba3421138ec96ebde5ce73e301 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 4 03:43:22 2022 +0100 server: refactor fromHtml attribute handling Also try to recognize owncast hashtag links. commit cda9197700b41c7ce75a3f9210df06854e7b591a Author: Johann150 <johann.galle@protonmail.com> Date: Sun Dec 4 03:26:50 2022 +0100 server: increase nodeinfo caching Changelog: Changed commit 2dde8273e2c6ade955223054de49ff36ada59a30 Merge: 18cf228f8 6600f6e52 Author: Chloe Kudryavtsev <toast+git@toast.cafe> Date: Sat Dec 3 13:33:23 2022 +0000 implement separate web workers Reviewed-on: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/252 commit 7924d5d01be204380db2d7cc6527a1431ca7c1a5 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Nov 27 11:30:34 2022 +0100 add oauth documentation commit de927e1f30e19cd47827ac765b81402df6d1a0d7 Author: Johann150 <johann.galle@protonmail.com> Date: Thu Nov 10 21:16:55 2022 +0100 server: handle invalid URLs in comparison commit bdcec2b8a72d7787c315da5355e95b7d044843e5 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Nov 6 18:45:50 2022 +0100 server: implement OAuth discovery (RFC 8414) commit 5291f2958155694252969f8bd0a92f26ee2a662e Author: Johann150 <johann.galle@protonmail.com> Date: Mon Nov 7 00:12:21 2022 +0100 implement OAuth PKCE This implements Proof Key for Code Exchange a.k.a. RFC 7636. commit 15b3ab6d1307048680e15511dce2a3c2e259062b Author: Johann150 <johann.galle@protonmail.com> Date: Mon Nov 7 00:10:48 2022 +0100 check redirect URIs commit 79e3c2018966a9645f4bcc86edea57a8367d3837 Author: Johann150 <johann.galle@protonmail.com> Date: Sat Nov 5 22:17:51 2022 +0100 server: allow to grant tokens with more restricted privileges This also simplifies API authentication a bit by not having to fetch the App that is related to a token. The restriction of 1 token per app is also lifted. This was not a constraint in the database but it was enforced by the code and kinda wrong schema the auth_session table had. commit 2f2e6a58a409129b967f361fe04b1368ed72aac7 Author: Johann150 <johann.galle@protonmail.com> Date: Wed Oct 19 09:04:45 2022 +0200 docs: read scope descriptions from locale strings commit c5568cfdf3f9d414ec8b387cba95e5a313230792 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Oct 16 21:09:30 2022 +0200 client: fix auth page layout This also includes better rendering when no permissions are requested. Also removed the app's id from the page as it makes no sense to show this to a user. Changelog: Fixed commit c65fdebe2615068a02c6e8c5653f17d3fec4edfd Author: Johann150 <johann.galle@protonmail.com> Date: Sun Oct 16 20:59:21 2022 +0200 server: add missing auth/deny endpoint This endpoint is hinted at in the client, but is not actually defined in the backend. This commit defines it. commit 418c88bb8fb48f54dfe14f884143f9956f42be55 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Oct 16 06:24:55 2022 +0200 expire AuthSessions after 15 min commit 2b19b341962f0d7122f77646768127c16f47698c Author: Johann150 <johann.galle@protonmail.com> Date: Sat Oct 15 16:14:16 2022 +0200 update OpenAPI docs to OAuth commit 7db7fdd9e2d7114fa8c99aa0bfe9d88ac043536a Author: Johann150 <johann.galle@protonmail.com> Date: Sun Oct 16 01:11:47 2022 +0200 add API route for OAuth access token retrieval commit a13e956af00b0acdafcc22d4067b63459bc03bc4 Author: Johann150 <johann.galle@protonmail.com> Date: Sun Oct 16 00:46:13 2022 +0200 make authorization token granting OAuth 2.0 compatible This is basically a shim on top of the existing API. Instead of the 3rd party, the web UI generates the authorization session. The data that the API returns is slightly adjusted so that only one API call is necessary instead of two. commit 18cf228f893806e690be37729c75d66b32080784 Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 3 05:12:08 2022 -0500 server: readd "fetch meta only once in skippedInstances"" This reverts commit e446a11bb7ed10875eceb50cbd4261523ae4de4f. Turns out this wasn't really the source of the referenced issue and someone was able to run with the original commit fine, so adding this back for now. commit bdf2e14a73a067b5165aad2e0bfced8ff235a156 Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 3 04:01:51 2022 -0500 server: fix TypeError in registerOrFetchInstanceDoc Changelog: Fixed commit c5cf167ffa2314777a0e45acb5a635fa994611db Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 3 02:18:08 2022 -0500 server: fix ReferenceError: meta is undefined Ref: e446a11bb7ed10875eceb50cbd4261523ae4de4f Changelog: Fixed commit e446a11bb7ed10875eceb50cbd4261523ae4de4f Author: Francis Dinh <normandy@biribiri.dev> Date: Sat Dec 3 02:13:18 2022 -0500 Revert "server: fetch meta only once in skippedInstances" This reverts commit 81d63720f2671f83e24432c8052b1f2efea6c1c7 since it seems to cause a ReferenceError for some reason. Ref: https://toot.site/…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Run
tsc --noEmit
in the service worker build stepWhy
Currently the service worker build never typechecks, since esbuild and typescript-eslint don't do such job.
esbuild: https://esbuild.github.io/content-types/#typescript
typescript-eslint: https://typescript-eslint.io/linting/troubleshooting#why-dont-i-see-typescript-errors-in-my-eslint-output
Adding this step adds tons of TS errors 😱
Additional info (optional)