Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): show Unicode emoji tooltip with its name #9399

Merged
merged 4 commits into from
Dec 25, 2022

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Dec 22, 2022

What

  1. MkReactionViewer and MkEmoji now shows the tooltip with the name when including Unicode emoji, lazily computed on pointerenter
  2. Some TypeScript related refactoring

Why

  1. Searching from an array with 2000 items for every emoji felt like too energy-consuming, so I decided to do it lazily on pointerenter. (But I have no actual performance profile 🤔)
  • altはOSで各言語に読めるようになるので変更不要 / alt is not changed here as OSes should be able to read it in each language.
  1. For less warnings

Additional info (optional)

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #9399 (6bf1e0f) into develop (1b6473a) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6bf1e0f differs from pull request most recent head fcca335. Consider uploading reports for the commit fcca335 to get more accurate results

@@             Coverage Diff             @@
##           develop    #9399      +/-   ##
===========================================
- Coverage    22.42%   22.42%   -0.01%     
===========================================
  Files          702      702              
  Lines        65774    65777       +3     
  Branches      2127     2127              
===========================================
  Hits         14748    14748              
- Misses       51026    51029       +3     
Impacted Files Coverage Δ
...kages/backend/src/server/WellKnownServerService.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina tamaina merged commit decde50 into misskey-dev:develop Dec 25, 2022
@syuilo
Copy link
Member

syuilo commented Dec 25, 2022

  • altを削除すると、テキストをコピーしたときに絵文字が消えます
  • Searching from an array with 2000 items for every emoji felt like too energy-consuming

    • これはコード内にコメントとして残しておくと良いと思います。

syuilo added a commit that referenced this pull request Dec 25, 2022
@saschanaz saschanaz deleted the emoji-tooltip branch December 25, 2022 08:07
yu256 pushed a commit to yu256/akatsukey that referenced this pull request Mar 5, 2023
…v#9399)

* enhance(client): show Unicode emoji tooltip with its name

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: tamaina <tamaina@hotmail.co.jp>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants