Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): dvh polyfill #9617

Closed
wants to merge 2 commits into from
Closed

fix(client): dvh polyfill #9617

wants to merge 2 commits into from

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jan 16, 2023 •
edited
Loading

Fix #9187

iOS 15や古いChromeのためにdvhをpolyfillする

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #9617 (b321b6d) into develop (9d64ac6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #9617   +/-   ##
========================================
  Coverage    22.62%   22.62%           
========================================
  Files          731      731           
  Lines        68480    68480           
  Branches      2028     2028           
========================================
  Hits         15495    15495           
  Misses       52985    52985

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina
Copy link
Contributor Author

tamaina commented Jan 16, 2023

https://github.com/joppuyo/large-small-dynamic-viewport-units-polyfill 追加するの忘れた

@tamaina tamaina changed the title fix(client): dvh fallback fix(client): dvh polyfill Jan 16, 2023
@tamaina tamaina requested a review from syuilo January 16, 2023 08:24
@tamaina
Copy link
Contributor Author

tamaina commented Jan 16, 2023

p1.a9z.devで動作中

@tamaina
Copy link
Contributor Author

tamaina commented Jan 16, 2023

Container QueryもPolyfillあるけどいる？

@syuilo
Copy link
Member

syuilo commented Jan 16, 2023

Vueみたいに動的に追加するケースだと作動しない気がした

@tamaina
Copy link
Contributor Author

tamaina commented Jan 16, 2023

ふむ
このPolyfillについてはCSS Variableなので全然平気

https://github.com/joppuyo/large-small-dynamic-viewport-units-polyfill/blob/master/src/index.js

@syuilo
Copy link
Member

syuilo commented Jan 17, 2023

iOS15サポートしないとしているし要らない気がする

@tamaina
Copy link
Contributor Author

tamaina commented Jan 17, 2023

iOS15サポートしないとしているし要らない気がする

方針を転換してほしい

@syuilo
Copy link
Member

syuilo commented Jan 17, 2023

もうリリースしてしまったしなあ
あとdvhのpolyfillだけ入れたところでというのがある

@tamaina
Copy link
Contributor Author

tamaina commented Jan 17, 2023

うだうだ言わないでさっさとマージして13.0.1リリースしろよdvh以外はたぶんとりあえず問題ないような感じはある

@tamaina
Copy link
Contributor Author

tamaina commented Jan 17, 2023

あー、でもそんなこと言ってたらいつまで経ってもiOS 15のことを考えなければならない

@tamaina
Copy link
Contributor Author

tamaina commented Jan 17, 2023

iOS 15はなかったことにするわ

@tamaina tamaina closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo Awaiting requested review from syuilo

Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The navigation bar has disappeared in Google Chrome at v12.120.0-alpha.8.
2 participants
@tamaina @syuilo