Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny UNIX domain socket #9802

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Conversation

mei23
Copy link
Contributor

@mei23 mei23 commented Feb 5, 2023

What

DownloadのリクエストでUNIXドメインソケットなどの意図しないプロトコルを拒否するように

Why

Downloadで使用しているgotでは以下のようなURLでUNIXドメインソケットにアクセスを試みてしまう模様。

unix:/tmp/unix.sock:/x
http://unix:/tmp/unix.sock:/x

Additional info (optional)

現状gotのUNIXドメインソケットの実装が壊れているので悪用は出来ないと思う

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 5, 2023
@syuilo
Copy link
Member

syuilo commented Feb 5, 2023

デフォルトでtrueなのか🤯 13.xからはfalseになるみたいだけど...

@syuilo syuilo merged commit 505ecf6 into misskey-dev:develop Feb 5, 2023
@syuilo
Copy link
Member

syuilo commented Feb 5, 2023

🙏🏻🙏🏻🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants