General Issue/Feedback

[mistervee]

No description provided.

[mistervee]

Feedback from Gibxxi/Dan

Very nice. It looks suitably polished, I think you can be proud of this version of Madnox, even at this early stage. I would however suggest that you give end users an option to use the classic Aeon font for the main menu at least, as while the new one is OK, it does look a bit "squashed" if that's the right word, even on a 16:9 display. Also, I'd double the RSS feed scrolling speed (at least), as it's a bit on the slow side.

I'd stick with "Live TV" as a pose to just "TV" for the main menu PVR item by default, to clarify the distinction between "TV Shows" (i.e: rips) and "Live" broadcasts. Also, this is probably already on your todo radar, but in the library stats panel, i think it might be a good idea to also place the "Recordings" stats, alongside the number of channels, as before.

Issues:

In the info panel in "List View" there's an extra horizontal line that is above the bottom level of the info box (plot outline / synopsis), that interferes/intersects with the text as it scrolls. Also, text in that box seems to be right-justified rather than centre-justified at the moment. This applies to Movies and TV shows. None of the "Poster Views" are working, as well as some other views, but I'm guessing it's because you haven't completed these yet. "Wall View" works for videos (Movies and TV) but not for Music. "Wall - Info View" doesn't work for anything. Finally it's not possible to scroll down below "Wide List" in the Side-blade View Selector, whereas it is possible to scroll all the way if coming up from the bottom, however, "Big List" and "Landscape List" are skipped if doing so.

[mistervee]

Feedback from Gibxxi/Dan

Just taken another look and realised why the synopsis is "right-justified". It's because of the lack of the scrollbar for some shows with a short synopsis. Also the slider button and the text are right next to each other. If it were me, i'd keep the scrollbar on the (traditional) right-hand-side, and make it always active / visible but maybe hide or "grey-out" the button to make it obvious it's not required in that case. This will present consistent look and avoid having to re-justify the text for short synopsis text blocks that do not require a scrollbar. Also, a small margin between the text and said scrollbar (3-4px) would make it look a little neater (IMHO).

[mistervee]

@bartolomesoriano @gibxxi @Slipass

Giving some thought to only providing feedback to one area at a time (i.e. Theme/Color picker) that may not be the best approach.

I have realized, (thanks to feedback from @gibxxi) that feedback for everything is better. I do know there are many unfinished area and things do not work as expected in some views.

So please post whatever you like, anything that you think needs updating, fixed, changed, suggested improvements or what ever you do and do not like. Even for what you think is unfinished as i can get it in a semi functional/polished state.

So then i will either comment it out from the code or do some adjustments for the short term.

EDIT:
I think everything should look good and function nicely regardless on what part of the code i am working on. I get too focused on one part of the skin and neglect other parts with updates, and have often (over the past year) break other parts of the skin with out updating other areas. So yeah feedback for what ever you like.

As everyone here has full access to github, you can open new issues. What ever you want to do. So please be as detailed, OCD'd, criticize, complain and be as constructive as you like
https://github.com/mistervee/skin.madnox/issues/new

The only thing i ask is do not push anything to github.

[bartolomesoriano]

@mistervee, I was looking into the colorbox script error in DialogVideoInfo.xml. It seems that the script author does not support much anymore the running of the script via RunScript(), and the preferred method is using the daemons provided by the script, which is a whole different way of running it. Look here: https://forum.kodi.tv/showthread.php?tid=318626&pid=2696277#pid2696277

Perhaps that is the answer, or else will have to code the using of colorbox via the daemons.

[mistervee]

@bartolomesoriano
Makes sense. But strangely enough, today, i open Kodi and no more error?

Feel free if you want to try to get it working.

I had a quick look and it seems i will need to invest loads of time in understanding the script as there is not really any Wiki of sorts. So for me i will look at this way down the track or remove it all together.

[bartolomesoriano]

@mistervee, I did what that post suggested (enclosing the image name in $ESCINFO[]), and the error went away. However, I don't know if it is doing what you wanted to achieve, since I cannot see any changes in the poster image in the dialog. Could you try that and see if it is working? Or let me know what you were trying to achieve?
I know there's very little documentation, but I see it as a challenge of sorts. Please let me know what you wanted to do with the poster in the dialog, and I will figure out how to achieve that with the script and post here what changes would be required. Thanks!

EDIT: I tried the latest Leia nightly 64-bit (Oct. 14) and I still get the error with the unmodified dialog. I am using the latest version available in Git of the colorbox script.

[gibxxi]

@mistervee

Aeon Nox had a "Power Menu" which had only one function, to bring up the shutdown dialog box. I don't think we need a dedicated "Shutdown" menu item on the main menu, but for those who run Kodi, only using a remote control, especially for those without a built-in alphanumeric keyboard, relying on the "S" shortcut alone will make exiting Kodi / restarting more difficult.

With that in mind, would it be possible to add a "Power" option to the "System -> Submenu" item, so that we can invoke the shutdown pop-up dialog from there?

[bartolomesoriano]

@gibxxi You don't have to rely on the S key for power. What @mistervee has in MadNox is that on the main menu, if you press down once, you'll get to the submenu for that option, and if you press down again you get to a bottom tab that has Power, Search, Favorites, Update Library, Disc and Eject Disc. These options for the bottom tab are configurable in Skin Settings.

[bartolomesoriano]

@mistervee , I am seeing these errors in the log:

INFO: Error loading include file C:\Users\bsori\AppData\Roaming\Kodi\addons\skin.madnox\16x9\script-skin_helper_service-includes.xml: Failed to open file (row: 0, col: 0)
11:12:48.182 T:22244
ERROR: Error loading include file C:\Users\bsori\AppData\Roaming\Kodi\addons\skin.madnox\16x9\Custom_Overlay.xml: Root element required.

The first one I understand is because we don't have that file in the skin, but the second one I don't understand. I looked at the Custom_Overlay xml and could not find anything wrong with it.

[bartolomesoriano]

@mistervee, there are some more errors I am seeing in the log. I will post here for your review.

1. WARNING: Skin has invalid include: FullScreenDimensions
   From what I could see, this is because this include is in Includes_Temp.xml, and this file is not being referenced so it can be loaded in Includes.xml.

2. WARNING: Skin has invalid include: Animation_Slide_Right
   This include is not in any of the xmls for the skin.

3. WARNING: Skin has invalid include: Animation_VisibleFade
   From what I could see, this is because this include is in Includes_Temp.xml, and this file is not being referenced so it can be loaded in Includes.xml.

4. WARNING: Skin has invalid include: Animation_WindowFade
   This include is not in any of the xmls for the skin.

5. [Warning] CGUITextureManager::GetTexturePath: could not find texture 'lists/focus.png'
   [Warning] CGUITextureManager::GetTexturePath: could not find texture 'buttons/thumbnail_focused.png'
   [Warning] CGUITextureManager::GetTexturePath: could not find texture 'panels/topbar-shadow-empty.png'
   DEBUG: [Warning] CGUITextureManager::GetTexturePath: could not find texture 'panels/topbar-shadow20.png'
   [Warning] CGUITextureManager::GetTexturePath: could not find texture 'views/scrollbarbacklist.png'
   [Warning] CGUITextureManager::GetTexturePath: could not find texture 'separator2.png'
   [Warning] CGUITextureManager::GetTexturePath: could not find texture 'buttons/button-focus.png'
   These textures are not in the skin folder.

6. WARNING: Label Formating: $VAR[SystemBackground] is not defined
   WARNING: Label Formating: $VAR[MusicBackground] is not defined
   WARNING: Label Formating: $VAR[VideoBackground] is not defined
   These variables are not defined in any of the XMLs.

These are all of the ones I think you should take a look at. There are more, but they relate to parts of the skin not yet recoded, like PVR and other views (right list, info list).

[gibxxi]

Ah, thanks for that. I think he mentioned that before. I'd forgotten about it. :) On Oct 14, 2018 3:48 PM, bartolomesoriano <notifications@github.com> wrote: @gibxxi<https://github.com/gibxxi> You don't have to rely on the S key for power. What @mistervee<https://github.com/mistervee> has in MadNox is that on the main menu, if you press down once, you'll get to the submenu for that option, and if you press down again you get to a bottom tab that has Power, Search, Favorites, Update Library, Disc and Eject Disc. These options for the bottom tab are configurable in Skin Settings. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGyQ6kN3MSLZ5G6EhsrYHOBmLZDUl3LLks5uk06wgaJpZM4XMEjp>.

[mistervee]

@bartolomesoriano
I fixed some of the log errors you have mentioned.

The PVR area you should expect log errors as that is not complete. Mainly in the guide xml.

The missing textures are due to the many changes/updates/OCD in improving textures. Using a spreadsheet i am trying to keep track of what i have not reviewed.

Hopefully when an Alpha version is close i will have resolved most of the errors, then i will post the spreadsheet on git.

So for now i would not think to much about any log errors that are in the skin.

EDIT:
The script-skin_helper_service-includes.xml error is likely to do with not selecting any backgrounds the skin helper service scripts provide. Need to think about how to handle this in future.
If you go to the side menu in settings and select a library background the error should no longer be present.

[bartolomesoriano]

@mistervee, thanks. There is still one include that is used in a lot of places that is not defined because the only place where it is defined is in Includes_Temp.xml: FullScreenDimensions.

This is also not defined, which pertains to music:

19:27:48.747 T:26912 WARNING: Label Formating: $VAR[MainMenuNowPlayingMusicCaseVar] is not defined

I thought form the commits that you worked on the music part a bit, if this is not the case ignore this error.

On another note, I noticed that the scrollbar nib in the List view appears inside the texture, not straddling the edge of the texture, which I personally preferred. Was this change by design or is it maybe something to do with the aspect ratio of my laptop monitor?

[mistervee]

@bartolomesoriano

Cheers for the bug reports.

Seems the 'S' was not uppercase in some xmls.

Updated the Case variable for now playing. Now playing is not complete but the error is no longer an issue.

Corrected the position of the scrollbar. That was something i missed when changing the main panel of the list view. My design choice was to center the texture on the edge of the panel, same goes for all the dialogs.

I am open to a change for the scrollbar. Not sure where i should position it or maybe improve the texture? Thoughts?

[gibxxi]

Talking of music, not sure if it's complete, so I'll post it here... "Wall View" in the music library is using movie poster aspect artwork, as a pose to square (like a CD case), noticed this the other day, but forgot to mention it.

[bartolomesoriano]

@bartolomesoriano

Cheers for the bug reports.

Seems the 'S' was not uppercase in some xmls.

Updated the Case variable for now playing. Now playing is not complete but the error is no longer an issue.

Corrected the position of the scrollbar. That was something i missed when changing the main panel of the list view. My design choice was to center the texture on the edge of the panel, same goes for all the dialogs.

I am open to a change for the scrollbar. Not sure where i should position it or maybe improve the texture? Thoughts?

@mistervee, my opinion is to leave the scrollbar as you have it, on the right edge of panels. I noticed there are some panels where it is on the left edge; I need to look at it again to tell you which ones in particular. Was this by design?

[bartolomesoriano]

@mistervee, I checked some more just now. The following panels do not have a scrollbar:

• List View for Movies, TV Shows, Music Videos.
• Manage Sources panel

I saw the scrollbar on the left for the Subtitle language selection panel (in Settings, for which subtitle language you prefer).

I guess from those you can tell where you did not include the scrollbar and where you have it on the left. Please let me know if you need additional info. Thanks.

[mistervee]

@gibxxi
Wall view is not complete. I will get to updating the views when i have finished all other areas of the skin.

@bartolomesoriano
The scrollbar position you see in the subtitle dialog was by design. In every view/dialog it is positioned directly left or right of the list it controls. How i decided what side of the the list was for ease of navigation.

I did however find some non related issues with the subtitle dialog. (missing rating, textbox size and scroll).

For the panels without a scroll bar, It is a coding mistake throughout the skin. I have used the same id for a lot of the scrollbars. So things are not working as intended. When i get to focusing on the views, i will fix the issue.

[gibxxi]

@mistervee: OK, just checking. :)

[mistervee]

@bartolomesoriano
and
@ALL

All log error's should be fixed apart from what is listed here
#34

If you have any issues please post in the above mentioned thread.

[bartolomesoriano]

@mistervee, two issues:

1. The infoline label for the Videos main menu item says "Videos: " and then a movie count at the start of the label. I understand it should be "Movies: ".

As far as I can tell, the issue is that, in Variables.xml, in line 519, you need to replace [COLOR $VAR[MainMenuSubTextColorVar]]$LOCALIZE[3] : with [COLOR $VAR[MainMenuSubTextColorVar]]$LOCALIZE[20342] :

2. When viewing TV Shows in List view, the Next Aired properties which appear at the bottom right (part of the MediaFlagsRight include) do not update properly; I guess that when for a specific list item the properties are not filled, the values from the last item which had values are still shown.

I took a closer look at the addon code, and it seems we are using outdated properties to show the info.
There is no "StatusID" property anymore, just "Status", and there is no "Today" property anymore; I guess "NextDate" needs to be used and compared against today's date. I hope this info is useful.

[mistervee]

@bartolomesoriano

1. Fixed

2. This is something that is bugging me. The skin is using the 'marcelveldt's beta repo'. In that repo is a update version of the 'Next Aired plugin' that seems to have some issues. Try going into addons/programs, context menu, then info. Press the refresh icon to change the version to the kodi repo one 6.0.15. marcelveldt's version is causing issues with widgets also in other skins.

This is something i need to look into further to see what i can update/improve, in regards to the use certain plugins.

[bartolomesoriano]

@mistervee, thanks! Confirm that 1 is fixed and I will do as you suggest for 2.

[bartolomesoriano]

@mistervee, with the 6.0.15 version of next aired plugin the info shown is correct.

[Slipass]

I don't know if it's been posted yet......so double it up rather than nothing.

Currently, "List" and "Wall" are always preselected. If you select a different view, "List" and "Wall" also remain highlighted.

[gibxxi]

@Slipass:

Those aren't menu items m8, they're section titles, hence the colour. If you look, there are two "Liste" items and two "Wall" items in the sideblade. One is the section title, the other is the actual (selectable) menu item.

Dan / Gib.

[mistervee]

@bartolomesoriano @gibxxi @Slipass

Hi all,

Hope you had a great Christmas and new year.

I have just pushed an update to git.

I have decided to move onto the library views for now, as i needed a change of pace with the coding. I will get back to the other areas of the skin at some point.

This is a WIP and bug reports are NOT required. There is a lot i have broken and not finished, just needed a git backup in case of a PC meltdown.

I do have a few questions though, any assistance, feedback would be great;

• The Topbar and Floor and an option to disable
  I have three options here

1. Enable/Disable for all views and areas of the skin. A global setting
2. Option to disable for each area of the skin. videos, music addons ect. So this will affect all views for a specific area of the skin
3. Option to disable for each view.

Option 1 is the easiest to code. Option 2 has a few more visibility conditions, and not so hard to code. Option 3, makes the code more complex and introduces a lot more overhead. and may have a small impact on performance.

My preference is option 2. I either want to show the topbar and floor in specific skin areas or not.

Just needing some thoughts on this in regards how you would use this feature.

• Default Icons, DefaultFile.png ect in the media folder
  The current icons are nice. 2 issues, they require a transparent background to play nice with the skin. They resolution is to low for 4k displays.

I am looking for some one to volunteer to put a set of icon together using the google icon font. It is easy to do, just time consuming. It is a couple of clicks in a program i have to make 1 icon.

• Media flags.
  The resolution is to low for 4k.
  It is a matter of google searching for them and resizing in image editing program. This is a rather large task to complete and needs some basic image editing skills. Using photoshop or paint.net

Cheers
Mr. V

EDIT: If anyone one is up for helping point 2 or 3, i can get on discord to guide you.

[bartolomesoriano]

@mistervee , thanks for the update! I will test this weekend.

As for the TopBar and Floor, I agree with you on option 2. I have never changed those for specific views and not others.
I can help with the Default Icons. Just let me know what I need to do. I have not used Discord before, but that should not be an issue.

EDIT: @mistervee what is your Discord link? I created an account and server. I can provide my Discord link if you want.

[gibxxi]

I concur with option 2. I don't think adjustments "per view" are warranted, and if said option were to reset to defaults on each new view, I think it could cause a lot of frustration for some users, that's in addition to all the extra work required by you to code it.

I run different views per media type, so may wish to adjust floor options etc. based on that, so option 2 would suit my way of doing things.

I'll get it updated later and see what's new, welcome back btw.

;)

Dan / Gib.

[Slipass]

18: Is it possible that the submenu is only displayed when you press down?
And the shadow is adjusted a little bit more to the old Madnox?

See my previous post about the shadow color. Same steps as previously outlined. But main menu settings.

The submenu, I can look at that in future.

[Slipass]

A general question for everyone.
What do you think of this view?
It's not from Madnox, but I think it looks nice and clean.

[gibxxi]

That's Arctic Zephyr. I also use that skin, but I don't think we should be importing views / layout / design elements from other skins that weren't already part of Aeon Madnox (1.0). That's Plagiarism at best. I like Arctic Zephyr (Not so sure about 2.0 - at this stage), but if I want that look for a change, i'll simply switch to that skin, from Madnox and vice-versa.

Also, while I'm here, it might be an idea to post "links" to your screenshots in this thread Slipass, as posting lots of images will cause massive slowdowns of page loads. Github doesn't seem to support pagination, so the entire thread will be loaded on a single page, thus causing massive slowdowns, the more remote images it needs to load. Just an idea, no offence intended.

[Slipass]

Hello together....
Right, the view is from Arctic Zephyr.
It was only the consideration, if you can rebuild such a view in the style of Madnox.

Concerning the screenshots you are right, but the loading times were still ok with me.
For a better overview, I wanted to post it directly instead of just the link.
But I can also post only the link.

Greetings

[mistervee]

@meowmoo

Thankyou. Appreciate your feedback.

@gibxxi @Slipass

Sorry a late response. I have been quite busy with work and coding in the past week.
I will take a look at your feedback and make some improvements. Need a bit of time to get through it all.

BTW i am ok with images in the each github discussion.

As @gibxxi said the threads get a little slow with images, and they slow down further the more posts your have. I am trying to split up the discussion based on an area of the skin and what feedback is needed at the time. This will keep the post count low,make github faster loading and make easier for me to address your feedback, so i don't miss anything.

Any feedback for the views should be in this thread
#42

I will respond in the other thread, when time permits.

Just pushed another update, details in the other thread.

Cheers All

[meowmoo]

In the furniture settings you can't select top bar, by pressing down you can't reach the other options, pressing up will jump from quick nav to enable/disable views

[mistervee]

@Slipass

First of all, I think it's great how well the skin is developing. It looks really great.

Thankyou.

1: In movies and series it is not possible to have a view without the fanarts.

2: Even if I choose Single Image, it won't be showed

I made some changes some time ago and removed skin helper service. Backgrounds are not working as they should. When the views are finished i will look at other parts of the skin.

3: The Video Preview is only in full screen (background.
But I find this very impractical, because you hardly see anything of the video. Here I find the window mode (picture in picture) much better

I will add the option to the views in future.
Added to the first post in the 'To Do' list in this thread
#42

4: There are no Disc Art Fallback

In the first post in the 'To Do' list in this thread. Artwork fallbacks.
#42

5: The Showcase View has no "fixed list" you can scroll infinitely. I find a "fixed list" better

In the first post in the 'To Do' list in this thread. Artwork fallbacks.
#42

6: No Box Art

Maybe? In the first post in the 'To Do' list in this thread. Artwork fallbacks.
#42

7: Is it in the future possible to add other cases?

Not sure for now. I would rather only have one case type. Much easier from a coding perspective only having one case type to deal with.

[mistervee]

9: The progress is not shown in the icons.

I have no plans to add this feature. It is something personally i would not like to use. Not to mention the amount of time it would take to create this.

If i added this i would have to create 100 images and would take me a full day complete.

10: In the Music view you cannot scroll in steps of 10

Not sure what the problem is. The scroll bar seems to be working.

11: The fanarts are no longer displayed because the logic is still based on the old artwork downloader.

Should be working. All the artwork use kodi infolabels, none of the old madnox method exists in the skin.

If kodi is setup like this there should be no issues
https://kodi.wiki/view/Movie_artwork

12: I found the old info view in the movies a bit more clearly/structured.

No plans to change how it looks. I do agree it looks a little cluttered, So in future i will remove the director/writer info to make it consistent with the list views.

12: Question: Will you also plan further views for music and radio plays? I liked the 3D view in the old Madnox

Not sure what you mean by music and radio plays?

I will not be adding any 3d view to the skin. This is really a personal preference, not so keen on adding too much that i will not use, that will also take a lot of time to complete.

13: The old view at "LiveTV" was a bit clearer. The Info List 1 is not so nice as the "Complete overlay"
For example, the progress bar and the channel name are missing in the new Live TV

This was a design choice. I find the progress bar and channel name makes the view look cluttered.
Instead of the progress bar the start and finish time is shown, i find this much more useful than a progress bar.
The channel logo is shown instead of the name. I find this a much cleaner way of identifying what channel is shown.

14: LiveDVD Background still missing

After they views are finished, i will get to it, just not my focus for now.

15: Maybe I'm image but I can't find the repositories for the addons :)

I need to recode this area of the skin.

Click on addon browser button.

16: I think the old Shadowbar didn't look so good and it fits better with the skin

Change the topbar theme to shadow
Change the shadow color to black
Change the shadow 'opacity' to 0%
Change the texture color to black
It should look similar.

17:The Pause menu is still missing

Still working on the views. Not finished coding yet.

[mistervee]

@Slipass

18: Is it possible that the submenu is only displayed when you press down?
And the shadow is adjusted a little bit more to the old Madnox?

See my previous post about the shadow color. Same steps as previously outlined. But main menu settings.

The submenu, I can look at that in future.

[mistervee]

@meowmoo

In the furniture settings you can't select top bar, by pressing down you can't reach the other options, pressing up will jump from quick nav to enable/disable views

Fixed

[mistervee]

@Slipass

Updated the texture for the topbar.

If you change the settings as i mentioned it will be the same as Aeon madnox.

[gibxxi]

Having an issue quitting Kodi using Madnox 2.0. And this only seems to be an issue for Madnox 2.0 in my case. Possibly unique to my addon setup, as I don't see anyone else posting about it, but it is consistent across all 3 systems I run Kodi on.

Under Kodi Leia 18.2, using Madnox 2.0, upon exiting Kodi, it will hard freeze 99.5% of the time. The Kodi log gets as far as "Unloading Skin", but no further entries appear in the log, CPU usage is 0% and the process needs to be task-killed by Task Manager.

There are 4 addons that are leaving some things in memory (see below) but this behaviour does not seem to ocurr with Aeon Madnox (1.0). To clarify, I'm not aware if these log entries are created or not with Aeon Nox 1.0 as I haven't checked, but neither does it hard lock on exit nearly as much either. The method doesn't matter; Be it Exit / Restart or Shutdown. All produce the same end result (Kodi hard freezing).

2019-06-16 13:17:10.836 T:16508 WARNING: CPythonInvoker(119, D:\Kodi Media Center\portable_data\addons\plugin.video.amazon-test\service.py): the python script "D:\Kodi Media Center\portable_data\addons\plugin.video.amazon-test\service.py" has left several classes in memory that we couldn't clean up. The classes include: class XBMCAddon::xbmcaddon::Addon,class XBMCAddon::xbmcgui::Dialog

2019-06-16 13:17:10.844 T:18104 WARNING: CPythonInvoker(3, D:\Kodi Media Center\portable_data\addons\plugin.video.twitch\resources\lib\service_runner.py): the python script "D:\Kodi Media Center\portable_data\addons\plugin.video.twitch\resources\lib\service_runner.py" has left several classes in memory that we couldn't clean up. The classes include: class XBMCAddon::xbmcgui::Window

2019-06-16 13:17:11.336 T:8936 WARNING: CPythonInvoker(5, D:\Kodi Media Center\portable_data\addons\script.artwork.beef\service.py): the python script "D:\Kodi Media Center\portable_data\addons\script.artwork.beef\service.py" has left several classes in memory that we couldn't clean up. The classes include: class PythonBindings::XBMCAddon_xbmc_Monitor_Director,class XBMCAddon::xbmcgui::DialogProgressBG

2019-06-16 13:17:14.371 T:3692 WARNING: CPythonInvoker(23, D:\Kodi Media Center\portable_data\addons\service.scrobbler.lastfm\scrobbler.py): the python script "D:\Kodi Media Center\portable_data\addons\service.scrobbler.lastfm\scrobbler.py" has left several classes in memory that we couldn't clean up. The classes include: class PythonBindings::XBMCAddon_xbmc_Monitor_Director,class PythonBindings::XBMCAddon_xbmc_Player_Director

Whether these leftovers are in any way related to interactions between the skin itself and the addons (progress bars / dialogs / etc.) I can't say, as I'm not a coder or a skinner, and do not understand Python very well. Suffice to say, exit only seems to hang for me (with regularity) in Madnox 2.0.

Dan / Gib.

[mistervee]

That's a tough one to answer.

All i can think of is it may relate to skin helper service in some way?

I have had issue in the past with the addon and kodi not shutting down as it should. Mainly due to some issues with skin helper trying to retrieve artwork. I have not fully removed all of skin helper artwork in the skin yet. Code still remains for music now playing and some background selection. I will get to that in time.

If you remove the skin helper addon does help?

[gibxxi]

...Possibly. I can't out-right remove it, as it's a dependancy for a few other skins (including Madnox 1.0 - which is still my daily-driver) so i temporarily renamed the folder.

Exited (gracefully) 1st time after a 10 second delay or so, but this is normal given the number of add-ons I have installed i guess. I'll keep it that way on the testing machine (Desktop) and just use Madnox 1.0 on the other two for now, and see how it goes. Let me know if you want to see a log, i'll PM you one on the Kodi forums if your interested.

Dan / Gib.

[mistervee]

If time allows i will try to remove the remaining code from skin helper in the next couple of weeks. If you are still having issues after that, it will be time for a log.

[meowmoo]

I set up Madnox as my Daily Skin, and im more than happy with it! and this in an alpha stage...
I need to say it again...Awesome work mistervee.

The only thing im missing are the watched flags, but im sure the will come "soon"

[gibxxi]

Hi Mr. V,

Small problem with "Low List" view when used at the "Season" level for TV shows. Season posters are not displayed, and instead a generic "folder" is displayed.

I'd like to say, also, that the skin is looking very good. It's not yet quite mature enough for me to switch to it full time, but it's not far away either. Good work all-round, so thanks for that.

:)

Dan / Gib.

[mistervee]

@bartolomesoriano @gibxxi @Slipass @meowmoo

Just a observation. I am going through some of the threads and there is a lot of feedback i have missed.

You need to use @mistervee if you are posting feedback or I sometimes do not receive an email notification. I only check github when i am pushing a new commit or responding to a notification i have via my email account.

EDIT: I have been doing this too on some posts. Could be a reason you may have not seen my response.

[mistervee]

@meowmoo

I set up Madnox as my Daily Skin, and im more than happy with it! and this in an alpha stage...
I need to say it again...Awesome work mistervee.

The only thing im missing are the watched flags, but im sure the will come "soon"

Glad you like it. 😃

I will get to the watched flags in the next couple of weeks.

[mistervee]

@gibxxi

Hi Mr. V,

Small problem with "Low List" view when used at the "Season" level for TV shows. Season posters are not displayed, and instead a generic "folder" is displayed.

I'd like to say, also, that the skin is looking very good. It's not yet quite mature enough for me to switch to it full time, but it's not far away either. Good work all-round, so thanks for that.

:)

Dan / Gib.

Showing fine from my end

If you don't see season posters here you should not see them in all of the list views on the season level. They are using the same variables for the artwork.

The only other thing i can think of is artwork names and how you have scraped your artwork.
When using kodi with artwork beef the season poster is in this listitem
$INFO[ListItem.Art(poster)]

For artwork to update with artwork beef you need to have "Add artwork for new videos after library updates" selected in the addon settings.

My TVShow directory looks like this

Or do you mean the "*all seasons" item? That one will be the same issue no matter what skin you use.

[gibxxi]

@mistervee

It's OK Mr. V, it's an issue my end. I have 3 systems running Kodi, but a common storage area for some Kodi artwork (the stuff artwork beef downloads), which is then cached to the local devices. One of them (the one I wasn't getting artwork for) was out of sync with the others, or so it seems at this point in time.

AB will add pre-existing artwork every time it runs (usually after startup library scans in my case). If there's a system I haven't powered on in a while, getting all 3 systems "on the same page" for want of a better phrase, can take a while.

Will monitor it going forwards, but at this stage, looks to be a non-issue, so apologies for that.

:)

Dan / Gib.

[mistervee]

@gibxxi
Glad you got it sorted

[gibxxi]

@mistervee

Navigational issue with "Add-ons" menu items from home screen / main menu (Music & videos sections):

When navigating into either "Add-ons" sections for music or video (Home menu -> sub-menu) items, the add-on currently highlighted in the "Cover" list view will be background loaded simply by scrolling over that addon's entry in the list.

With some add-ons (like rainymood.com for music) this then presents an infinite loop as attempting to back out of the add-on from it's default of fullscreen mode, goes back to the previous menu, but the add-on launches itself again and it goes back to fullscreen. For the video section, the Youtube add-on will suffice to demonstrate the issue. Before you ask, I did not at any time press the ENTER key.

Also, (unrelated) the on-screen keyboards (both standard & mini-numeric) the left & right arrow keys are replaced by hollow square boxes (UK English Language settings).

Dan / Gib.

[mistervee]

@gibxxi

In general, if you open an addon kodi automatically fills the list content from what ever is provided by the addon.

Before i consider troubleshooting, can you check if you have the same issue in Estuary, the default skin. This is always the first thing to check when you are having addon issues like you have mentioned. If it is an issue in other skins it is likely not related to the skin code.

I have seen similar issues with some addons like spotify, if the addon settings do not have the correct username or password.

PLEASE let me know what happens in kodi's default skin.

For the keyboard, a change to the font some time ago broke the icons. I will try to fix that next update.

[gibxxi]

@mistervee

That's just the point Mr. V. I'm not opening the addon. I'm simply scrolling down through the list of addons, and in doing so it's automatically opening the highlighted / selected addon, The "Enter" keystroke also seems to be being sent several layers into the addon itself too, assuming that addon or addons are using list views.

I tested the same functionality in Estuary, and it's not happening there. Neither does it occur in Madnox 1.0. Somehow an "Enter / Return" keystroke is being sent in those sections, and only those sections in the skin.

This happens on all my systems, with Madnox on, so it's not a hardware issue either. The HTPC and laptop, each controlled by a Motorola NYXboard remote control, and the desktop, using a Roccat Isku FX keyboard, so there's no commonality with hardware either.

EDIT: The strange aspect to this is that some of those add-ons get foreground focus, and others are denied it. At no point during scrolling is my finger anywhere near the "Enter" key, nor do I have any custom keystroke mappings defined anywhere in any of my Kodi instances.

Dan / Gib.

[mistervee]

@gibxxi

Just installed rainy mood. I am getting the same behavior. For what ever reason it tries to load the addon when you navigate over it.

Will take me some time to work out what is happening.

EDIT: It is to do with the album/song count. I have a hidden container with the folder path. It loads every-time you go into mymusic, hence trying to load the addon.

[gibxxi]

@mistervee

Good find Mr. V. I'm getting the same behaviour with add-ons in the "videos" submenu too. Try scrolling over the YouTube add-on if you have that installed, and see if you get the list of categories automatically appear.

I'll disable rainymood for now.

Dan / Gib.

[mistervee]

DONE