Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backgrounds - rework #40

Closed
mistervee opened this issue Apr 7, 2019 · 15 comments
Closed

Backgrounds - rework #40

mistervee opened this issue Apr 7, 2019 · 15 comments

Comments

@mistervee
Copy link
Owner

mistervee commented Apr 7, 2019 •
edited
Loading

As a reminder for future updates due to the removal of skin helper.

Also;
Genre fanart
Animated backgrounds
Live backgrounds
Extra fanart working for now playing and all views
Update skin settings area to be better structured
Improve animation transition times
@mistervee mistervee mentioned this issue Apr 7, 2019
Closed
@gibxxi
Copy link

gibxxi commented Jul 28, 2019 •
edited
Loading

@mistervee

I've started using the "Skin Playlist" backgrounds for the home menu (Random Movies, Random TV Shows, and Random Artists). The on-screen display time for these I measured at about 7 seconds, with a transition between images of less than a second. Also I can't find any option to "animate" the backgrounds.

Would it be possible to add options to extend the image display time / transition length and animate the backgrounds (as per Aeon Madnox 1.0)?

If any of these options already exist (and I'm looking in the wrong place), could someone please point me in the right direction? The artwork change transition is a little to fast for my liking, and I like background animated fanart. I'd go with a minimum display time of 10 seconds for each image with somewhere between 1 & 2 seconds for the transition.

Dan / Gib.

@mistervee
Copy link
Owner Author

@gibxxi
It is set to 7 seconds. I can add an option for a time, but one less setting is better. Any thoughts on what time you would like? (In future i can add an option if it is required, would rather stick too a set value)

The transition/overlap time for the images (after 7s) is 400ms. This is consistent throughout the skin with opening windows and dialogs. I would like to keep this the same. If i slow this down the skin will feel slower overall.

Animated backgrounds are not yet an option. In the first post on the to do list.

@gibxxi @bartolomesoriano @meowmoo

All
Any thoughts on the time the skin moves to the next fanart image?
People have different tastes, so trying to gauge wether or not an option is required?

@gibxxi
Copy link

gibxxi commented Jul 29, 2019 •
edited
Loading

I'd like to set it to 10 seconds for now. That's what I set my pictures / photos slideshow settings to. It gives you chance to roam around the picture with your eyes before it changes to the next image. That 3 extra seconds doesn't sound much but it is a noticeable difference.

TIA,

Dan / Gib.

@mistervee
Copy link
Owner Author

@gibxxi
In the middle of updating the theme selector and home screen. So will be a bit of time before any update.

Lets see what the others think in regards to time. I am ok with 10s.

In regards to my previous comment, only having one set time;
Opposite to what i was saying before, Thinking though may be it is best to have an option for 10/15/20/25/30s. It might better suit the masses once out in the forums.

NOTE: Sometime i am slow in my reply (giving me time to think it over) and others too quick without enough thought. Hence my change of mind. (I need to drink less beer)

@bartolomesoriano
Copy link
Collaborator

@mistervee , if possible , I would also prefer an option for different times. I like your idea of 10/15/20/25/30.

@meowmoo
Copy link
Contributor

meowmoo commented Jul 29, 2019 •
edited
Loading

@mistervee
10sec is fine for me, I edited it in madnox1 artistslideshow code back in the days, it also was 7sec if I remember correctly.

An option to use like 5,10,15,20,25,30 sec sound as a good idea to me, I'm pretty sure someone will ask in the future if it is possible to set a different timing.

@gibxxi
Copy link

gibxxi commented Jul 29, 2019 via email

@gibxxi
Copy link

gibxxi commented Jul 29, 2019 via email

@gibxxi
Copy link

gibxxi commented Jul 29, 2019

@mistervee

While we're on the subject, why not change all transition durations in Madnox 2.0 to either 500ms or 1 sec? Would this not just involve a simple search & replace in the code?

Either are nice round, numbers, and the longer transition times would make the animation appear smoother. As it stands, the transitions complete so quickly as to be barely perceptible as transitions at all.

I take the image background transition as an example. So much as blink, and you miss it. It almost appears as if the images are "hard cut" from the previous to the next, almost like there is no transition present at all. I'm not the most observant of people, so maybe I'm missing something here.

Not wanting to come across as pushy. If your satisfied with it, the way it is, then stick with it. But for me, I'm having difficulty understanding how you came to the 400ms value in the first place.

Dan / Gib.

@mistervee
Copy link
Owner Author

mistervee commented Jul 30, 2019 •
edited
Loading

@gibxxi

Changing the transition time is something i planned for way back.
Most of the tags are using an include for the backgrounds.
EDIT: this also applys to the transitions in a list view for the poster.

I am sure i have 95% coded to to this. (it is actually 300ms not 400, my mistake)

In the includes.xml there is a constant 'TextureFadeTime'. Change this and it should affect most of the skin.

Please Let me know what you think a nice transition time is.

The value i picked was to do with animations of the various panels, opening and closing windows. Generally i thought a similar time would be better for a smoother looking skin.

@gibxxi
Copy link

gibxxi commented Jul 30, 2019

Dialog boxes aren't so critical, and probably 300-500ms will be fine. At the end of the day, the user's focus isn't going to be so much tuned to that, but for backgrounds, which take up more screen real estate, and the user is going to be more consious of during changes, I think they will benefit from slightly longer transition times. I'll have a play about and let you know what I think.

Dan / Gib.

@gibxxi
Copy link

gibxxi commented Jul 30, 2019 •
edited
Loading

@mistervee

While testing some settings for background duration, I noticed on the home screen (main menu) that if you scroll between categories, i.e: "Movies" to "TV Shows" the background fanart (Using Skin Playlist backgrounds) does not change until the scheduled interval. Not sure if this ocurrs with other backgrounds as these are untested by me at this time.

Also, if you scroll between categories just before a transition is due to ocurr, the next background to load will still be from the previous category, but it will instantly reload the background again, with one for the correct main menu category currently focused. When this happens, it seems to use the 300ms default transition speed and not the one I modified in the includes.xml file. Either that, or it's switching image halfway through the transition. To me is looks like the former rather than the latter, but I'm not 100% sure.

As for transition times, I tried 500ms, 1000ms and 2000ms. In the end 2000ms (2 seconds) won it for me. 1000ms was better than the default, but still looked a little on the "hurried" side. With that in mind, I'd suggest a setting of 500 & 1000ms for dialogs & pop-ups respectively, and 2000ms for background artwork transitions.

@mistervee
Copy link
Owner Author

mistervee commented Aug 1, 2019 •
edited
Loading

@gibxxi

Personally i find 2000ms too long. I am happy with the animation times for dialogs and popus as they are. This looks like it would be worthwhile adding in some custom settings to change how the transitions/animation work.

Added to the todo list in the first post.

EDIT: I really appreciate the feedback and it helps me to improve the skin where i can. i am updating the home screen/widgets/theme selector atm. When the time is right i will get to it.

@gibxxi
Copy link

gibxxi commented Aug 1, 2019

@mistervee

Each to their own I guess m8. Either way, thanks for putting this on your to-do list. Not an urgent issue at any rate,

Dan / Gib.

@mistervee
Copy link
Owner Author

DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mistervee @gibxxi @bartolomesoriano @meowmoo