Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D plot tests, plot test suite fixes and rcParams fix #461

Merged
merged 19 commits into from
Jun 20, 2020

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented Jun 15, 2020

This PR addresses issues #460, #304 and #297 .

  • the similarity criterion for comparing plots to the expected result in the test suite is tightened
  • a bug with overlapping title and suptitle is addressed by using constrained layouts
  • matlplotlib's current rcParams will be modified by the plotter instead of the mpl defaults
  • a set of 3D plots test is added
  • all plots test are updated because of the overlap fix

@coveralls
Copy link

coveralls commented Jun 15, 2020

Pull Request Test Coverage Report for Build 1024

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • 85 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.04%) to 80.203%

Files with Coverage Reduction New Missed Lines %
tests/openmoc/openmoc/materialize.py 1 73.82%
src/Mesh.cpp 2 40.7%
tests/openmoc/openmoc/plotter.py 82 88.97%
Totals Coverage Status
Change from base Build 1014: 1.04%
Covered Lines: 13219
Relevant Lines: 16482

💛 - Coveralls

@GiudGiud GiudGiud merged commit 00b79fa into mit-crpg:develop Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants