Stop using deprecated methods from libjsoncpp #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FastWriter and StyledWriter have been deprecated by upstream libjsoncpp. Switch to the recommended StreamWriterBuilder instead and manually specify our desired Json stringify style. For classes like Blockchain which keep a Storage poiner around all the time, we should refactor to uses a shared rather than static writer object to save time when writing Json to string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastWriter and StyledWriter have been deprecated by upstream libjsoncpp. Switch to the recommended StreamWriterBuilder instead and manually specify our desired Json stringify style. For classes like Blockchain which keep a Storage poiner around all the time, we should refactor to uses a shared rather than static writer object to save time when writing Json to string.