accumulator/forestdata: Improvements to cowforest #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CowForest has slightly better caching now and faster flush and restore from disk. Is not backwards compatible with a previously saved cowforest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
Add caching strategy to cowForest.It has a slightly better caching now. cowForest treeBlocks (subtrees) now have a height of 1 (3 leaves). This makes the cowForest not backwards compatible with a previously saved cowForest.
Add stats for treeTable hits/misses. (misses are very low).
Add a test for writing the cowforest (tests flushes as well).
Flag for cowmaxcache now in MB instead of treeTable max count.