Refactor code to improve static type checking (DomainEntry dataclass) #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not provide any user-visible features, but it provides two development benefits:
... with a
DomainEntry
dataclass that allows the following usage:In the original form, the IDE (VSCode + Pylance) and linters / type checkers like
pylint
andpyright
could not tell the types of variableswe_connect
,coordinator
andvehicles
, which were deemed ’unknown’ and affected a chain of type checking wherever those variables were used. In the second form proposed in this PR, type checking is available.pylint
/pyright
to aid with type checking.Tested with Home Assistant version
2024.1.6
.