This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fallback to environment if values not specified for AppleId #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any values are not specified in the config file for `AppleId` we can fallback to pulling them from `AC_USERNAME`, `AC_PASSWORD`, and `AC_PROVIDER`. `AC_PASSWORD` will still be passed into `altool` using the `@env:` prefix as supported by `altool` to avoid printing sensitive information but all others will be read from the environment and passed by value to `altool`.
mitchellh
approved these changes
Nov 11, 2019
| if cfg.AppleId.Username == "" { | ||
| appleIdUsername, ok := os.LookupEnv("AC_USERNAME") | ||
|
|
||
| if ok { |
There was a problem hiding this comment.
This is fine, but I prefer to do a !ok check and exit, so that we don't need a full else case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any values are not specified in the config file for
AppleIdwe can fallback to pulling them from
AC_USERNAME,AC_PASSWORD,and
AC_PROVIDER.AC_PASSWORDwill still be passed intoaltoolusing the@env:prefix as supported by
altoolto avoid printing sensitiveinformation but all others will be read from the environment and
passed by value to
altool.Resolves #9