-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bummed out by breaking changes #66
Comments
You can install the 'icon' package v0.1.0 with Some substantial breaking changes weren't avoidable (such as changing the package name), and so with the migration from ropenscilabs and a complete rewrite of the package to use SVG instead of fonts, I made some design changes to improve the extensibility design of the package. |
Design changes to improve extensibility should be made with some consideration of backward compatibility. Also, you should publicize the availability of the old version. |
Apologies again for the breaking changes, I've added these install instructions to the README section noting the breaking changes. |
This is a disaster for me because the syntax for
icons
is so different, e.g.,icon::fa("rocket", color="red")
vs.icons::icon_style(fontawesome("rocket"), fill="red")
This is probably the worst example of breaking changes I have ever seen.
It means I will either have to revert to R 3.6 or else modify all the Rmd files for my web sites that use
r icon::fa()
You could have provided some cover functions to make the transition easier.
The text was updated successfully, but these errors were encountered: