-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve formula parser #131
Conversation
Now, in text mode, we translate $ a $ as #math.equation(block: false, $ a $); instead of using bare equation, to address the first bug. However, I'm not quite sure about the next two optional semantic errors, but they seem to be just edge cases. Should we not prioritize them for now? |
Sounds great before we having taken all whitespace into control.
You can do it now, but it is not urgent since they don't occur in regular document. In addition, this is not introduced by this PR and has stayed for a long time. |
Ok, I've added formula check. |
I have refactored the parser and added some tests for formulas.
During testing, I find a bug:
mitex/crates/mitex/src/lib.rs
Lines 1151 to 1156 in b85675a
And two optional semantic errors to handle:
mitex/crates/mitex/src/lib.rs
Lines 1157 to 1168 in b85675a