Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Loading reducer to be aware of new API actions #61

Closed
kadamwhite opened this issue Mar 13, 2017 · 0 comments
Closed

Update Loading reducer to be aware of new API actions #61

kadamwhite opened this issue Mar 13, 2017 · 0 comments
Assignees
@kadamwhite

Comments

@kadamwhite
Copy link
Collaborator

kadamwhite commented Mar 13, 2017 •
edited
Loading

We added new API actions, but did not update the loading indicator reducers to account for them. This should be cleaned up.
kadamwhite added a commit that referenced this issue Mar 13, 2017
@kadamwhite
Add tests & loading state handling for all sagas
bf9cf6a 
Fixes #61 by accounting for all AJAX pending states within the loading
reducer, and adds test coverage for all extant sagas
@kadamwhite kadamwhite mentioned this issue Mar 13, 2017
Merged
@kadamwhite kadamwhite self-assigned this Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kadamwhite kadamwhite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boazsender @kadamwhite