Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Use absolute path to __file__ #26

Merged
merged 1 commit into from
Mar 17, 2015
Merged

Use absolute path to __file__ #26

merged 1 commit into from
Mar 17, 2015

Conversation

carsongee
Copy link
Contributor

This should fix the readthedocs bug #25. I don't have enough SO rep to comment, but the code didn't properly path file. This adds that and makes the code look a little nicer. See http://pylmod.readthedocs.org/en/feature-cg-apidoc_debug/ for this PR cherry-picked onto @pwilkins api docs PR and note the version is correct

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ca55f559f2f063ddc43b8499565d820349fda0a7 on feature/cg/version_fix into db77d9f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ca55f559f2f063ddc43b8499565d820349fda0a7 on feature/cg/version_fix into db77d9f on master.

@pdpinch
Copy link
Member

pdpinch commented Mar 17, 2015

Just curious: what's the advantage of wrapping it in a function?

@carsongee
Copy link
Contributor Author

all those variables aren't exposed on the module (which they shouldn't be), also lowercase is more readable.

@carsongee
Copy link
Contributor Author

It would also be easier to test if we wanted to add one for this instead of no covering it

@carsongee
Copy link
Contributor Author

going to go ahead and write a test for this before we merge, but it should still help @pwilkins on his doc PR as is

@carsongee
Copy link
Contributor Author

Tests added

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 244534b on feature/cg/version_fix into db77d9f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 244534b on feature/cg/version_fix into db77d9f on master.

@pwilkins
Copy link
Contributor

Thank goodness you got to the bottom of this.

@pwilkins pwilkins closed this Mar 17, 2015
@carsongee
Copy link
Contributor Author

Umm, did you mean to close? I think you wanted merge

@carsongee carsongee reopened this Mar 17, 2015
pwilkins added a commit that referenced this pull request Mar 17, 2015
@pwilkins pwilkins merged commit 27ff539 into master Mar 17, 2015
@pwilkins pwilkins deleted the feature/cg/version_fix branch March 17, 2015 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants